fix: custom skull textures in placedskull not rendering (1.21.11)#2268
Merged
lineargraph merged 5 commits intoFirmamentMC:mc-1.21.11from Mar 5, 2026
Merged
fix: custom skull textures in placedskull not rendering (1.21.11)#2268lineargraph merged 5 commits intoFirmamentMC:mc-1.21.11from
lineargraph merged 5 commits intoFirmamentMC:mc-1.21.11from
Conversation
lineargraph
approved these changes
Mar 3, 2026
Collaborator
lineargraph
left a comment
lineargraph
left a comment
There was a problem hiding this comment.
this is more of a general skin changer that will also apply to mobs and such. that is probably fine, but i would like a more fine grained control flow later on. given the current state of not working i will probably merge this however and create an issue to split up that rendering (maybe with overrides like sophie wanted for a while)
lineargraph
changed the title
WilliamTTran
pushed a commit
to WilliamTTran/Firmament
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #2263