Skip to content

Revert "Switch to an xor for the checksum"#81

Merged
manish-pandey-arm merged 1 commit intoFirmwareHandoff:mainfrom
jmarinho:revert_checksum_to_sum
Dec 1, 2025
Merged

Revert "Switch to an xor for the checksum"#81
manish-pandey-arm merged 1 commit intoFirmwareHandoff:mainfrom
jmarinho:revert_checksum_to_sum

Conversation

@jmarinho
Copy link
Contributor

@jmarinho jmarinho commented Nov 20, 2025

This reverts commit ae94bd1, redefining the TL Header checksum field as a sum over all the TL bytes.

!Fix #78

This reverts commit ae94bd1.

Change-Id: Ifd39b925202988aa81cab60721183c443ba5ffac
Signed-off-by: Jose Marinho <jose.marinho@arm.com>
@manish-pandey-arm manish-pandey-arm merged commit 717c5b8 into FirmwareHandoff:main Dec 1, 2025
2 checks passed
LeviYeoReum added a commit to LeviYeoReum/edk2 that referenced this pull request Feb 3, 2026
Firmware handsoff specification withdraws "XOR" checksum usage
and update the specification checksum calculation with "SUM" [0].
So the libtl also updates with this change [1]

The "XOR" calculation was existed in v1,
but as above mentioned, it's withdrown, and
TF-A always gives the checksum with "SUM" calculation.

Therefore, just update the xferlist version to 2.

Link: FirmwareHandoff/firmware_handoff#81 [0]
Link: https://review.trustedfirmware.org/c/shared/transfer-list-library/+/46033 [1]
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
LeviYeoReum added a commit to LeviYeoReum/edk2 that referenced this pull request Feb 3, 2026
The Firmware Handoff specification has withdrawn
the use of the “XOR” checksum and updated
the checksum calculation to use “SUM” [0].
Accordingly, libtl has also been updated to reflect this change [1].

The “XOR” checksum calculation existed in version 1;
however, as mentioned above, it has been withdrawn, and
TF-A always provides the checksum using the “SUM” calculation.

Therefore, the xferlist version is updated to version 2.

Link: FirmwareHandoff/firmware_handoff#81 [0]
Link: https://review.trustedfirmware.org/c/shared/transfer-list-library/+/46033 [1]
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
mergify bot pushed a commit to tianocore/edk2 that referenced this pull request Feb 4, 2026
The Firmware Handoff specification has withdrawn
the use of the “XOR” checksum and updated
the checksum calculation to use “SUM” [0].
Accordingly, libtl has also been updated to reflect this change [1].

The “XOR” checksum calculation existed in version 1;
however, as mentioned above, it has been withdrawn, and
TF-A always provides the checksum using the “SUM” calculation.

Therefore, the xferlist version is updated to version 2.

Link: FirmwareHandoff/firmware_handoff#81 [0]
Link: https://review.trustedfirmware.org/c/shared/transfer-list-library/+/46033 [1]
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misalignment between checksum schemes in firmware handoff implementations

4 participants