use replace instead of insert to add extension#1
Closed
rasviitanen wants to merge 1 commit intoFishrock123:complete-refactor-traceidfrom
Closed
use replace instead of insert to add extension#1rasviitanen wants to merge 1 commit intoFishrock123:complete-refactor-traceidfrom
rasviitanen wants to merge 1 commit intoFishrock123:complete-refactor-traceidfrom
Conversation
Previously `ExtensionsMut::insert` was used without a guarantee that we had exclusive access to a SpanRef's extensions. This could lead to a panic in the `insert` function in the case where the extension was inserted concurrently by multiple calls to `eval_ctx`. By using `replace` the assertion is ignored and it no longer matters whether we have exclusive access or not to a span in `eval_ctx`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work at fixing some issues with this crate!
We are looking at moving to your fork due to the inactivity in the main repository.
This PR has to do with an issue when registering extensions, see original PR for more information:
inanna-malick#14
Please redirect me if I sumbitted this to the wrong branch.