Skip to content

Fix a bug in beir evaluation and release v1.3.4 #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanhainebula merged 2 commits into from
Feb 7, 2025
Merged

Fix a bug in beir evaluation and release v1.3.4 #1359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cdc494
fix beir eval bug: corpus_embd_save_dir is None
hanhainebula Feb 7, 2025
0921c45
release version 1.3.4
hanhainebula Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions FlagEmbedding/evaluation/beir/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ def __call__(
if sub_dataset_names is None:
if dataset_name is not None:
save_name = f"{dataset_name}-" + "{split}.json"
corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name)
if corpus_embd_save_dir is not None:
corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name)
else:
save_name = "{split}.json"

Expand Down Expand Up @@ -213,7 +214,8 @@ def __call__(
for sub_dataset_name in sub_dataset_names:
if dataset_name is not None:
save_name = f"{dataset_name}-{sub_dataset_name}-" + "{split}.json"
corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name, sub_dataset_name)
if corpus_embd_save_dir is not None:
corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name, sub_dataset_name)
else:
save_name = f"{sub_dataset_name}-" + "{split}.json"

Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setup(
name='FlagEmbedding',
version='1.3.3',
version='1.3.4',
description='FlagEmbedding',
long_description=readme,
long_description_content_type="text/markdown",
Expand All @@ -16,7 +16,7 @@
install_requires=[
'torch>=1.6.0',
'transformers>=4.44.2',
'datasets==2.19.0',
'datasets>=2.19.0',
'accelerate>=0.20.1',
'sentence_transformers',
'peft',
Expand Down
Loading