You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out the replacement of on_event into it's own PR
Done - kept the on_event change in this PR, I'll add everything else in a new one.
Update the title of this PR to not be a chore. This is too big a change to be a chore.
Edit: Changed to feat
Which would you prefer to use? I still think chore is the most representative, since we're not adding features or fixing bugs, or anything else in this list:
I agree this is a relatively risky change since we're changing how the core loop works, but I think it's still a chore at the end of the day. Happy to add functional/E2E tests if we need a different way to test this.
rolodato
changed the title
chore: Replace deprecated FastAPI on_event with lifespan event handlers
feat: Replace deprecated FastAPI on_event with lifespan event handlers
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: https://github.com/Flagsmith/edge-proxy/actions/runs/13836209807/job/38711754837
https://github.com/Flagsmith/edge-proxy/actions/runs/13820539759/job/38664556536#step:7:200
Now: