feat(initcontainers): add api volume mounts to init containers to sup… #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested changes
Jul 24, 2025
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Thanks @scarlson for submitting this - it makes sense to add these attributes. I've added a minor question, and then we can get this merged.
emyller
requested changes
Jul 24, 2025
Contributor
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I think it's a good idea overall to share volumes with essential containers.
I have only a few comments, can you please check?
| imagePullPolicy: {{ .Values.api.image.imagePullPolicy | default .Values.global.image.imagePullPolicy }} | ||
| args: ["migrate"] | ||
| env: {{ include (print $.Template.BasePath "/_api_environment.yaml") . | nindent 8 }} | ||
| env: {{ include (print $.Template.BasePath "/_api_environment.yaml") . | nindent 8 -}} |
Contributor
There was a problem hiding this comment.
I'm curious — did you find any issues that required chomping?
Contributor
Author
There was a problem hiding this comment.
required, no
env values in general have extra spacing from testing with helm template
…port SSL auth methods that require certs to be mounted
scarlson
force-pushed
the
init-container-mounts
branch
from
ca856c3 to
e92dd0e
Compare
matthewelwell
approved these changes
Jul 25, 2025
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Approving this but we'll hold off merging until the CI issues are resolved as per the comment here.
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port SSL auth schemas that require certs to be mounted
Thanks for submitting a PR! Please check the boxes below:
Changes
Add api volume mounts to
migratedbandbootstrapinit containers to allow for SSL auth schemas in those containers.How did you test this code?
Set volume mount values for properly mounting certs.
Rendered manifests with the changes and applied to test k8s cluster.