Skip to content

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jul 24, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

This PR turned out to be way more painful than I expected. The original goal was to revert this PR, which was added before we had release please to group releases. The key issue though is that release please and helm's chart-releaser-action do not work well together as they both want to create the github release and tag.

Useful references:

The new workflow steps added in this PR (generated with help from ChatGPT) essentially replace the work of the chart releaser action. The new flow is:

  1. Release please release PR is merged
  2. Release please action creates the github release and tag (in the format flagsmith-X.Y.Z for consistency)
  3. Release workflow is triggered on tag creation
  4. Release workflow builds the chart binary and uploads to the release created by release please
  5. Release workflow updates the gh-pages branch with new meta information on the release
  6. Change to gh-pages branch automatically triggers a rebuild of the GH pages site (which acts as the helm repo for flagsmith charts)

How did you test this code?

I've tested this by manually creating the flagsmith-0.75.0 tag from this branch, but the real test will be once we merge the next release please PR.

@matthewelwell matthewelwell requested a review from a team as a code owner July 24, 2025 21:47
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team July 24, 2025 21:47
emyller
emyller previously approved these changes Jul 24, 2025
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

emyller
emyller previously approved these changes Jul 24, 2025
@matthewelwell matthewelwell requested a review from emyller July 25, 2025 09:59
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@matthewelwell matthewelwell merged commit eedcf31 into main Jul 25, 2025
1 check passed
@matthewelwell matthewelwell deleted the chore(ci)/return-to-automated-publishing branch July 25, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants