-
Notifications
You must be signed in to change notification settings - Fork 44
chore(ci): automate publishing again #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matthewelwell
merged 15 commits into
main
from
chore(ci)/return-to-automated-publishing
Jul 25, 2025
Merged
chore(ci): automate publishing again #398
matthewelwell
merged 15 commits into
main
from
chore(ci)/return-to-automated-publishing
Jul 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
previously approved these changes
Jul 24, 2025
Contributor
emyller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
emyller
requested changes
Jul 24, 2025
emyller
previously approved these changes
Jul 24, 2025
2 tasks
emyller
approved these changes
Jul 25, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
This PR turned out to be way more painful than I expected. The original goal was to revert this PR, which was added before we had release please to group releases. The key issue though is that release please and helm's chart-releaser-action do not work well together as they both want to create the github release and tag.
Useful references:
The new workflow steps added in this PR (generated with help from ChatGPT) essentially replace the work of the chart releaser action. The new flow is:
How did you test this code?
I've tested this by manually creating the flagsmith-0.75.0 tag from this branch, but the real test will be once we merge the next release please PR.