Skip to content

feat: Support readiness probe overrides for API and Task processor deployments #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 2 commits into from
Jul 28, 2025
Merged

feat: Support readiness probe overrides for API and Task processor deployments #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03bcdbe
feat: Support readiness probe overrides for API and Task processor de…
khvn26 Jul 27, 2025
24127bb
sneaky typo
khvn26 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/flagsmith/templates/deployment-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,15 @@ spec:
successThreshold: {{ .Values.api.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.api.livenessProbe.timeoutSeconds }}
readinessProbe:
failureThreshold: {{ .Values.api.readinessProbe.failureThreshold }}
{{- if .Values.api.readinessProbe.exec }}
exec: {{ .Values.api.readinessProbe.exec | toYaml | nindent 12 }}
{{- else if .Values.api.readinessProbe.path }}
httpGet:
path: {{ .Values.api.readinessProbe.path }}
port: {{ .Values.service.api.port }}
scheme: HTTP
{{- end }}
failureThreshold: {{ .Values.api.readinessProbe.failureThreshold }}
initialDelaySeconds: {{ .Values.api.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.api.readinessProbe.periodSeconds }}
successThreshold: {{ .Values.api.readinessProbe.successThreshold }}
Expand Down
9 changes: 7 additions & 2 deletions charts/flagsmith/templates/deployment-task-processor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ spec:
exec: {{ $exec | toYaml | nindent 12 }}
{{- else }}
httpGet:
path: /health/liveness
path: /health/liveness/
port: {{ .Values.service.taskProcessor.port }}
scheme: HTTP
{{- end }}
Expand All @@ -100,11 +100,16 @@ spec:
successThreshold: {{ .Values.taskProcessor.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.taskProcessor.livenessProbe.timeoutSeconds }}
readinessProbe:
{{- $exec := .Values.taskProcessor.readinessProbe.exec | default .Values.api.readinessProbe.exec }}
failureThreshold: {{ .Values.taskProcessor.readinessProbe.failureThreshold }}
{{- if $exec }}
exec: {{ $exec | toYaml | nindent 12 }}
{{- else }}
httpGet:
path: /health/readiness
path: /health/readiness/
port: {{ .Values.service.taskProcessor.port }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.taskProcessor.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.taskProcessor.readinessProbe.periodSeconds }}
successThreshold: {{ .Values.taskProcessor.readinessProbe.successThreshold }}
Expand Down
15 changes: 11 additions & 4 deletions charts/flagsmith/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ api:
# runAsGroup: 1000
livenessProbe:
# path is the API path to be used for health checks. Used if exec is not set.
path: /health/liveness
path: /health/liveness/
# exec describes an ExecAction command which will run inside the API container.
# See https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#Probe
exec: {}
Expand All @@ -87,7 +87,10 @@ api:
successThreshold: 1
timeoutSeconds: 2
readinessProbe:
path: /health/readiness
path: /health/readiness/
# exec describes an ExecAction command which will run inside the API container.
# See https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#Probe
exec: {}
failureThreshold: 10
initialDelaySeconds: 1
periodSeconds: 10
Expand Down Expand Up @@ -206,6 +209,10 @@ taskProcessor:
successThreshold: 1
timeoutSeconds: 30
readinessProbe:
# exec describes an ExecAction command which will run inside the API container.
# Defaults to api.readinessProbe.exec.
# See https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#Probe
exec: {}
failureThreshold: 10
initialDelaySeconds: 1
periodSeconds: 10
Expand Down Expand Up @@ -397,14 +404,14 @@ sse:
# runAsUser: 1000
# runAsGroup: 1000
livenessProbe:
path: /health/liveness
path: /health/liveness/
failureThreshold: 5
initialDelaySeconds: 5
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 2
readinessProbe:
path: /health/readiness
path: /health/readiness/
failureThreshold: 10
initialDelaySeconds: 1
periodSeconds: 10
Expand Down
Loading