Skip to content

Conversation

@gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 27, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

This implements a temporary fix due to the changes introduced by this [1]. I also looked into other ways to handle this, e.g., using a different image with the same Bitnami chart or moving to a different chart. All of those options also feel like temporary fixes, so we might as well move to bitnamilegacy for now. The permanent fix would be to move away from the Bitnami chart entirely, use the Docker images directly, and handle the minimal setup that the Bitnami charts currently provide.
[1]: #386

How did you test this code?

Installed this chart on minikube

@gagantrivedi gagantrivedi requested a review from a team as a code owner August 27, 2025 10:31
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team August 27, 2025 10:31
Zaimwa9
Zaimwa9 previously approved these changes Aug 27, 2025
Copy link

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context but makes sense

khvn26
khvn26 previously approved these changes Aug 27, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor question.

@gagantrivedi gagantrivedi dismissed stale reviews from khvn26 and Zaimwa9 via 42c2635 August 27, 2025 10:43
@gagantrivedi gagantrivedi requested a review from khvn26 August 27, 2025 10:43
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gagantrivedi gagantrivedi merged commit fa84b73 into main Aug 27, 2025
2 checks passed
@gagantrivedi gagantrivedi deleted the fix/386-bitnami-source branch August 27, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants