feat: migrate to new flag engine with context value support#39
Merged
gagantrivedi merged 5 commits intomainfrom Nov 18, 2025
Merged
feat: migrate to new flag engine with context value support#39gagantrivedi merged 5 commits intomainfrom
gagantrivedi merged 5 commits intomainfrom
Conversation
Zaimwa9
requested changes
Nov 17, 2025
Zaimwa9
left a comment
There was a problem hiding this comment.
Overall looks good, couple of questions. Even though I'm positively surprise by the ease of reading/manipulating Rust, I might not be the best suited one for syntax/language specifics
Zaimwa9
approved these changes
Nov 18, 2025
Zaimwa9
left a comment
There was a problem hiding this comment.
Ok thanks for your answers. To me it's good like this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the SDK to use the new flag engine with context value support and includes critical error handling improvements and validation enhancements.
Changes
🚀 Engine Upgrade
flagsmith-flag-enginearchitecture in order to support context valuesget_environment_flags()to properly ignore segment overrides🐛 Critical Bug Fixes
FlagsmithClientErrorandFlagsmithAPIErrorwere displaying incorrect messages.unwrap()with proper error handling in polling thread to prevent silent failures✨ Enhancements
ser.)anyhow,eyre, and other error handling crates🧪 Tests
Breaking Changes
None - all changes are backward compatible
Related Issues
Fixes issues with: