Skip to content

feat: Log environment IDs in SDK endpoints #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 3 commits into from
Apr 22, 2025
+13 −6
Merged

feat: Log environment IDs in SDK endpoints #5365

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c614d51
feat: Log environment IDs in SDK endpoints
khvn26 Apr 21, 2025
f6244b9
add missing setting
khvn26 Apr 22, 2025
50b5e83
bump flagsmith-common
khvn26 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/environments/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from common.gunicorn.utils import log_extra
from django.conf import settings
from django.core.cache import caches
from rest_framework.authentication import BaseAuthentication
Expand Down Expand Up @@ -38,6 +39,11 @@ def authenticate(self, request): # type: ignore[no-untyped-def]
if api_key.startswith(SERVER_API_KEY_PREFIX)
else RequestOrigin.CLIENT
)
log_extra(
request=request,
key="environment_id",
value=environment.id,
)

# DRF authentication expects a two tuple to be returned containing User, auth
return None, None
16 changes: 10 additions & 6 deletions api/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ pygithub = "2.1.1"
hubspot-api-client = "^8.2.1"
djangorestframework-dataclasses = "^1.3.1"
pyotp = "^2.9.0"
flagsmith-common = "^1.9.0"
flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "feat/log-wsgi-extras" }
django-stubs = "^5.1.3"
tzdata = "^2024.1"
djangorestframework-simplejwt = "^5.3.1"
Expand Down
Loading