Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Nov 11, 2025

Closes #5825

Changes

Implementation Notes

Note

Migration 0030_add_default_to_segment_version:

  • Non-blocking and safe — schema-only change
  • Field remains nullable for backward compatibility
  • All existing segments already have version=1 (set by migration 0025_set_default_version_on_segment)

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 12, 2025 9:17am
flagsmith-frontend-preview Ignored Ignored Preview Nov 12, 2025 9:17am
flagsmith-frontend-staging Ignored Ignored Preview Nov 12, 2025 9:17am

@emyller emyller mentioned this pull request Nov 11, 2025
6 tasks
@github-actions github-actions bot added api Issue related to the REST API refactor labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.02%. Comparing base (f8a3381) to head (97a3b77).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6265      +/-   ##
==========================================
- Coverage   98.02%   98.02%   -0.01%     
==========================================
  Files        1280     1280              
  Lines       45408    45401       -7     
==========================================
- Hits        44510    44503       -7     
  Misses        898      898              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from a897539 to ee9c32c Compare November 11, 2025 04:33
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from ee9c32c to f23fbec Compare November 11, 2025 04:44
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from f23fbec to 335f90e Compare November 11, 2025 04:51
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 335f90e to 6a504db Compare November 11, 2025 05:36
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 6a504db to 0ebab10 Compare November 11, 2025 05:39
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 0ebab10 to 4fb8bad Compare November 11, 2025 05:41
@emyller emyller removed the refactor label Nov 11, 2025
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 6a1d7f3 to 83fd3d7 Compare November 11, 2025 13:55
@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 83fd3d7 to 095b6e0 Compare November 11, 2025 13:57
@github-actions github-actions bot removed the refactor label Nov 11, 2025
@emyller emyller marked this pull request as ready for review November 11, 2025 14:12
@emyller emyller requested a review from a team as a code owner November 11, 2025 14:12
@emyller emyller requested review from gagantrivedi and removed request for a team November 11, 2025 14:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6265 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6265 Finished ✅ Results

@emyller emyller force-pushed the refactor/segment-change-requests-cleanup branch from 095b6e0 to e4d5b55 Compare November 11, 2025 19:08
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 10

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

matthewelwell
matthewelwell previously approved these changes Nov 11, 2025
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but nothing that I see as a blocker if we want to get this merged ahead of the sprint closure.

@matthewelwell matthewelwell merged commit c405d6e into main Nov 12, 2025
31 checks passed
@matthewelwell matthewelwell deleted the refactor/segment-change-requests-cleanup branch November 12, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up

4 participants