-
Notifications
You must be signed in to change notification settings - Fork 463
refactor(Segments): Clean up after Segment Change Request work #6265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6265 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 1280 1280
Lines 45408 45401 -7
==========================================
- Hits 44510 44503 -7
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a897539 to
ee9c32c
Compare
ee9c32c to
f23fbec
Compare
f23fbec to
335f90e
Compare
335f90e to
6a504db
Compare
6a504db to
0ebab10
Compare
0ebab10 to
4fb8bad
Compare
6a1d7f3 to
83fd3d7
Compare
83fd3d7 to
095b6e0
Compare
Docker builds report
|
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
095b6e0 to
e4d5b55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 10
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
matthewelwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, but nothing that I see as a blocker if we want to get this merged ahead of the sprint closure.
Closes #5825
Changes
Segment.version.default = 1at field level instead of using a hookInheritMoved to new branchMetadataSerializerMixinfromSerializerMakeMoved to fix(Segments): Improve data model around live segments #6275.Segment.version_of = nullthe indication for a live segmentImplementation Notes
Note
Migration
0030_add_default_to_segment_version:version=1(set by migration0025_set_default_version_on_segment)