Task scheduling fix #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Flaxoos
commented
May 5, 2025
Flaxoos
commented
- removed task releasing. now only lock acquisition is required
- Bump to 2.2.1
- This PR also includes version upgrades, curtosy of @kmayoral
- removed task releasing. now only lock acquisition is required - Bump to 2.2.1
- removed task releasing. now only lock acquisition is required - Bump to 2.2.1
kmayoral
reviewed
May 5, 2025
Comment on lines
88
to
89
| delay(freqMs.milliseconds * executions) | ||
| delay(executionBufferMs.milliseconds) |
kmayoral
reviewed
May 5, 2025
| launch { | ||
| app.stop() | ||
| } | ||
| }.joinAll() |
kmayoral
reviewed
May 6, 2025
...io/github/flaxoos/ktor/server/plugins/taskscheduling/managers/lock/redis/RedisLockManager.kt
Outdated
Show resolved
Hide resolved
kmayoral
previously approved these changes
May 6, 2025
Collaborator
kmayoral
left a comment
kmayoral
left a comment
There was a problem hiding this comment.
Added one question, thanks for cleaning the original up, appreciate it!
- ignore node_modules (found in .github)
- ignore node_modules (found in .github)
- removed acquire lock mutex, it's enough to rely on redis - added retry in TaskSchedulingPluginTest.kt as sometimes
This reverts commit b93d8d2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.