Skip to content

Fix crashes on iOS 10 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minimoog wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crashes on iOS 10 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
622d06e
Add NSCameraUsageDescription to avoid crash at startup
minimoog Jan 31, 2017
ce30e96
Fix crash in MetalImageView on iOS 10
minimoog Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CoreImageHelpers/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
<array>
<string>armv7</string>
</array>
<key>NSCameraUsageDescription</key>
<string>Needs access to camera</string>
<key>UISupportedInterfaceOrientations~ipad</key>
<array>
<string>UIInterfaceOrientationPortrait</string>
Expand Down
6 changes: 4 additions & 2 deletions CoreImageHelpers/coreImageHelpers/ImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class MetalImageView: MTKView
fatalError("Device doesn't support Metal")
}

isPaused = true
enableSetNeedsDisplay = false
framebufferOnly = false
}

Expand All @@ -56,11 +58,11 @@ class MetalImageView: MTKView
{
didSet
{
renderImage()
draw()
}
}

func renderImage()
override func draw(_ rect: CGRect)
{
guard let
image = image,
Expand Down