Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs codebase maintenance including cleaning up OpenSpec documentation, updating the dependency to use Apple's official swift-binary-parsing repository instead of a fork, removing obsolete Swift attributes, and streamlining the Xcode scheme configuration.
Key Changes:
- Switched from forked swift-binary-parsing to official Apple repository
- Removed
@_lifetimeattributes that are no longer needed - Cleaned up OpenSpec files and AI assistant instructions
- Removed redundant test target definitions from Xcode scheme
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/* | Removed all OpenSpec specifications, project documentation, change archives, and AI instruction files |
| CLAUDE.md, AGENTS.md | Removed OpenSpec instruction files from repository root |
| .github/prompts/* | Removed OpenSpec prompt templates for proposal, apply, and archive workflows |
| .gemini/commands/openspec/* | Removed Gemini AI command definitions for OpenSpec operations |
| .claude/commands/openspec/* | Removed Claude AI command definitions for OpenSpec operations |
| Sources/BinaryParseKit/Protocols/ParsableProtocols.swift | Removed @_lifetime(&input) attributes from protocol method signatures |
| Sources/BinaryParseKitClient/main.swift | Removed @_lifetime(&input) attribute from extension implementation |
| Package.swift | Changed swift-binary-parsing dependency from fork to official Apple repository |
| Package.resolved | Updated dependency resolution to point to official Apple repository with new revision |
| README.md | Updated description to reference official swift-binary-parsing, marked length matching feature as complete |
| .swiftpm/xcode/xcshareddata/xcschemes/BinaryParseKit-Package.xcscheme | Removed redundant Testables section (test plans already define test targets) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FlickerSoul
force-pushed
the
chore/cleanup
branch
from
fad9268 to
6389522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR