feat(subMenu): use subMenu instead of menu#228
Draft
Mara-Li wants to merge 24 commits intoFlorianWoelki:mainfrom
Draft
feat(subMenu): use subMenu instead of menu#228Mara-Li wants to merge 24 commits intoFlorianWoelki:mainfrom
Mara-Li wants to merge 24 commits intoFlorianWoelki:mainfrom
Conversation
It allows a cleaner obsidian file-menu experience because instead to have 3 different command, we have only one that open a subMenu with the 3 commands. Note: It doesn't work on mobile, so we need to check mobile before loading the subMenu.
…-folder into FlorianWoelki-main
Owner
|
I love that everything is sorted into one submenu. However, I have a problem with the submenu because it is only available on Desktop and it's not officially typed in obsidian. So I'll leave this PR open for now. |
Contributor
Author
|
Yeah, I hope they will release the sub-menu soon on mobile. It will be very useful, to be honest! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows a cleaner obsidian file-menu experience because instead to have 3 different command,
we have only one that open a subMenu with the 3 commands.
Note: It doesn't work on mobile, so we need to check mobile before loading the subMenu.