-
-
Notifications
You must be signed in to change notification settings - Fork 0
Publish Only for Certain Commit Message #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe pull request updates the GitHub Actions publish workflow. The branch specification for the push event is now provided in an inline array format, limiting it to the "main" branch. Additionally, a condition has been added to the build job so that it is only executed if the commit message starts with "Bump version to". The previous tag trigger has been removed. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant Wf as GitHub Workflow
participant Build as Build Job
Dev->>Repo: Push commit to "main"
Repo->>Wf: Trigger push event
Wf->>Wf: Check if commit message starts with "Bump version to"
alt Condition met
Wf->>Build: Run build job
else Condition not met
Wf-->>Dev: Skip build execution
end
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
11-11
: Remove Trailing Whitespace
Trailing whitespace was detected on this line. Removing it will help maintain code quality and prevent unnecessary diff noise in future commits.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 11-11: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/publish.yml
[error] 11-11: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
.github/workflows/publish.yml (3)
6-6
: Inline Branch Filter Update
The branch filter is now specified in an inline array as[ "main" ]
, which simplifies the configuration and improves readability.
12-12
: New Build Job Condition
The added condition using
if: ${{ startsWith(github.event.head_commit.message, 'Bump version to') }}
ensures that the build job runs only on commit messages starting with "Bump version to". Please verify that this condition covers all intended version bump commit scenarios.
1-63
: Overall Workflow Update
The workflow now restricts triggers to pushes on themain
branch and limits the build job to version bump commits by inspecting the commit message. Ensure that the removal of tag-based triggers is intentional and aligns with your publishing strategy.🧰 Tools
🪛 actionlint (1.7.4)
59-59: the runner of "softprops/action-gh-release@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 11-11: trailing spaces
(trailing-spaces)
Shouldn't do this, just publish on tag. |
All right. |
No description provided.