Skip to content

Use Microsoft.CodeAnalysis.CSharp 4.12.0 to fix appveyor build error #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025

Conversation

VictoriousRaptor
Copy link
Contributor

Summary

Use Microsoft.CodeAnalysis.CSharp 4.12.0 to fix the build error on Flow-Launcher/Flow.Launcher#3765. Appveyor uses a lower VS version and we can't fix it on our side.

Tests

Flow-Launcher/Flow.Launcher#3870 builds.

@VictoriousRaptor VictoriousRaptor self-assigned this Jul 26, 2025
@VictoriousRaptor VictoriousRaptor added the bug Something isn't working label Jul 26, 2025
@Jack251970 Jack251970 merged commit 90867d2 into main Jul 26, 2025
2 of 3 checks passed
@Jack251970 Jack251970 deleted the fix-appveyor branch July 26, 2025 16:04
Copy link
Contributor

coderabbitai bot commented Jul 26, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes update project files across several components by removing or downgrading dependencies on Microsoft.CodeAnalysis.CSharp and related packages, and incrementing the version numbers in Flow.Launcher.Localization. No source code or public API changes are present; all modifications are limited to project configuration files.

Changes

File(s) Change Summary
Flow.Launcher.Localization.Analyzers/Flow.Launcher.Localization.Analyzers.csproj Removed Microsoft.CodeAnalysis.CSharp reference; downgraded Microsoft.CodeAnalysis.CSharp.Workspaces.
Flow.Launcher.Localization.Shared/Flow.Launcher.Localization.Shared.csproj Downgraded Microsoft.CodeAnalysis.CSharp from 4.13.0 to 4.12.0.
Flow.Launcher.Localization.SourceGenerators/Flow.Launcher.Localization.SourceGenerators.csproj Removed Microsoft.CodeAnalysis.CSharp reference.
Flow.Launcher.Localization/Flow.Launcher.Localization.csproj Incremented version properties from 0.0.3 to 0.0.4.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Add README.md & Add package info #26: Adds detailed package metadata and README inclusion to Flow.Launcher.Localization.csproj, with both PRs modifying project-level properties in the same file.

Suggested reviewers

  • Jack251970

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a297d5 and 9a92661.

📒 Files selected for processing (4)
  • Flow.Launcher.Localization.Analyzers/Flow.Launcher.Localization.Analyzers.csproj (1 hunks)
  • Flow.Launcher.Localization.Shared/Flow.Launcher.Localization.Shared.csproj (1 hunks)
  • Flow.Launcher.Localization.SourceGenerators/Flow.Launcher.Localization.SourceGenerators.csproj (0 hunks)
  • Flow.Launcher.Localization/Flow.Launcher.Localization.csproj (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-appveyor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970
Copy link
Member

@VictoriousRaptor Could you please create a release PR with tag to publish a new version of Nuget package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants