-
-
Notifications
You must be signed in to change notification settings - Fork 0
Improve documents about xaml comments #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves documentation for XAML comments in the localization toolkit by adding guidance on how to add function summaries and customize parameter types and names for localization strings.
- Added documentation for adding summary comments to localization string functions
- Added documentation for customizing variable types and names in localization strings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdded documentation to localization-toolkit.md: XAML comment-based summaries and parameter-type notes, examples for localized strings with placeholders, and expanded Localized Enums guidance with per-field attributes Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
localization-toolkit.md (1)
62-69
: Fix typos and tighten wording for XAML summary commentsCorrect “summry” → “summary”, “xaml” → “XAML”, and clarify placement/intent so readers know this feeds IntelliSense for generated methods.
-If you would like to add summry for functions of localization strings, you need to comment strings in xaml files like this: +If you want IntelliSense summaries for generated localization methods, add an XML comment directly above the resource in your XAML file: ```xml <!-- <summary>Demo plugin name</summary> --> <system:String x:Key="flowlauncher_plugin_localization_demo_plugin_name">Demo</system:String></blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between d022ba563df9101a439159baa704a8f79343ddd8 and 4271bd9fa9688745dd219ded8d24077cc8edafb3. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `localization-toolkit.md` (1 hunks) </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary> * GitHub Check: build </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Tell users how to add summary and customize variable types & names