Skip to content

Fix issue that strings with parameters are not parsed automatically #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
Merged

Fix issue that strings with parameters are not parsed automatically #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Flow.Launcher.Localization.SourceGenerators/Localize/LocalizeSourceGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public partial class LocalizeSourceGenerator : IIncrementalGenerator
private static readonly Version PackageVersion = typeof(LocalizeSourceGenerator).Assembly.GetName().Version;

private static readonly ImmutableArray<LocalizableString> _emptyLocalizableStrings = ImmutableArray<LocalizableString>.Empty;
private static readonly ImmutableArray<LocalizableStringParam> _emptyLocalizableStringParams = ImmutableArray<LocalizableStringParam>.Empty;

#endregion

Expand Down Expand Up @@ -355,7 +354,8 @@ private static (string Summary, ImmutableArray<LocalizableStringParam> Parameter
{
if (comment == null || comment.Value == null || parameters.Count == 0)
{
return (null, _emptyLocalizableStringParams);
// If the comment is not a valid XML, the summary is null and the parameters are not updated
return (null, parameters.ToImmutableArray());
}

try
Expand Down Expand Up @@ -385,7 +385,8 @@ private static (string Summary, ImmutableArray<LocalizableStringParam> Parameter
}
catch
{
return (null, _emptyLocalizableStringParams);
// If the comment is not a valid XML, the summary is null and the parameters are not updated
return (null, parameters.ToImmutableArray());
}
}

Expand Down
Loading