change FirefoxKeywordBookmark's language from python to python_v2
#413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
technically it's fine because the only thing that matters is the language in |
taooceros
previously approved these changes
Nov 15, 2024
auto-merge was automatically disabled
November 16, 2024 03:38
Head branch was pushed to by a user without write access
taooceros
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently updated my
Firefox Keyword Bookmarksplugin to v0.1.0, which uses the V2 plugin api, so I changed the language key topython_v2in the repo, however the auto updater did not carry this update over to this repo.tl;dr the auto updater didn't update my plugin's language key so I have to do it manually