Add filename construct validation #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yusyuriv
approved these changes
Dec 15, 2024
Member
Yusyuriv
left a comment
Yusyuriv
left a comment
There was a problem hiding this comment.
LGTM. Removing the list comprehension is not very important as its impact on performance is negligible, so I approved the PR in case you don't want to remove the list comprehension.
| return [os.path.join(plugin_dir, filename) for filename in get_plugin_filenames()] | ||
|
|
||
| def get_plugin_filenames() -> list[str]: | ||
| return [file for file in os.listdir(plugin_dir)] |
Member
There was a problem hiding this comment.
It looks like you don't need a list comprehension in get_plugin_filenames as they return the same data, but list comprehension does slightly more work as it iterates through list one more time:
>>> [v for v in os.listdir('test')]
['script2.py', 'plugin.json', 'file.txt', 'script.py']
>>> os.listdir('test')
['script2.py', 'plugin.json', 'file.txt', 'script.py']
Suggested change
| return [file for file in os.listdir(plugin_dir)] | |
| return os.listdir(plugin_dir) |
Member
There was a problem hiding this comment.
I didn't notice the PR was on auto-merge. Oh well.
Member
Author
There was a problem hiding this comment.
Ah yes, my mistake, will correct it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and validate plugin file name be in the construct of -.json.
Tested:
Previous Nightlight version fails validation
Relates to #430