Skip to content

Conversation

@cibere
Copy link
Contributor

@cibere cibere commented Jan 29, 2025

Based on #420

This PR adds a notification that gets triggered in the python-passed.yml workflow, where when the DateAdded key gets added to a plugin, a notification is sent to discord stating that a new plugin has been uploaded. I tried to keep the embed similar to the one used for updates, but I made a couple of changes.

Notification Example

image

Overview of changes

  1. Added requirements to the update-tested.py script and python-passed.yml workflow
  2. added a release_hook function based on update_hook to discord.py
  3. have update-tested.py execute release_hook for new releases
  4. Added webhook_url to update-tested.py via a CLI argument
  5. I also fixed a couple of typehints so that my typechecker would stop yelling at me

@jjw24 jjw24 added enhancement New feature or request and removed bug Something isn't working Plugin Submission labels Feb 4, 2025
@cibere
Copy link
Contributor Author

cibere commented Feb 4, 2025

I also reverted most of the changes I made to send_notification and opted to interact directly with release_hook, since release_hook and send_notification take different parameters now.

@prlabeler prlabeler bot added bug Something isn't working Plugin Submission labels Feb 5, 2025
@cibere
Copy link
Contributor Author

cibere commented Feb 5, 2025

I decided to move send_notification back to updater.py since it's no longer being used in update-tested.py, and there are 2 discord webhook hooks in discord.py

@cibere cibere removed bug Something isn't working Plugin Submission labels Feb 5, 2025
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 merged commit 9fdbbfe into Flow-Launcher:plugin_api_v2 Feb 5, 2025
5 checks passed
@cibere cibere deleted the plugin-release-webhook branch February 5, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants