-
Notifications
You must be signed in to change notification settings - Fork 161
New Plugin: Wallpaper Changer #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Plugin: Wallpaper Changer #470
Conversation
|
Is there a specific reason that you've chosen to not use the builtin settings system? |
|
I used a text file for storing the API key to keep it simple. If using the built-in settings system is preferred, I can update it |
If you don't have a specific reason to use a different method, could you please switch to the builtin settings system? Using the builtin settings system would also allow the user to set the API key through your plugin's settings menu, which aligns with how the rest of the plugins work. |
|
C:\Users\Username\AppData\Roaming\FlowLauncher\Settings\Plugins\Wallpaper
Changer
i am storing the file in this location is that correct
…On Mon, Feb 24, 2025, 5:54 AM cibere ***@***.***> wrote:
I used a text file for storing the API key to keep it simple. If using the
built-in settings system is preferred, I can update it
Plugin settings are stored in a different place than the plugins
themselves, so could you please either store your file in that location or
switch to the builtin settings system?
—
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAHY2WI7L73C52F5AUZV3F32RJRCTAVCNFSM6AAAAABXWGLYVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGIYTENRZGA>
.
You are receiving this because you modified the open/close state.Message
ID: <Flow-Launcher/Flow.Launcher.PluginsManifest/pull/470/c2677212690@
github.com>
[image: cibere]*cibere* left a comment
(Flow-Launcher/Flow.Launcher.PluginsManifest#470)
<#470 (comment)>
I used a text file for storing the API key to keep it simple. If using the
built-in settings system is preferred, I can update it
Plugin settings are stored in a different place than the plugins
themselves, so could you please either store your file in that location or
switch to the builtin settings system?
—
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAHY2WI7L73C52F5AUZV3F32RJRCTAVCNFSM6AAAAABXWGLYVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGIYTENRZGA>
.
You are receiving this because you modified the open/close state.Message
ID: <Flow-Launcher/Flow.Launcher.PluginsManifest/pull/470/c2677212690@
github.com>
|
That seems to be the correct directory, however I still think it would be best to use the builtin settings system. In case you are unaware how to use the builtin settings system, see the docs for how to define the settings, and for getting them in your code, iirc you can use |
|
I've updated the plugin to use the built-in settings system as suggested using flox. The API key is now stored within Flow Launcher's settings system instead of a text file |
|
I appreciate you switching your storage method to use flow's settings system, however I also wanted you to use the You can keep your current code, I'm just asking for the addition of that file |
|
Done , added the SettingsTemplate.yaml file |
|
Hey @cibere, I’ve made all the changes you suggested , Let me know if there’s anything else needed |
Thank you for all of the changes that you've made. |
Change Wallpaper with the help of Pexel Api