Skip to content

Conversation

@Odotocodot
Copy link
Contributor

@Odotocodot Odotocodot commented Mar 14, 2025

@jjw24
Copy link
Member

jjw24 commented Mar 30, 2025

Just a suggestion, I think instead of hooking into visibility change event, which triggers everytime flow is shown, it might also work just via the query method. If you hook into the event when users each time trigger flow to search then your code to look for the Lively process is ran as well.

Alot of times it's better to narrow down the plugin processing to when the plugin is actually called/used. I don't think the get process call is a heavy one so I will approve this.

@jjw24 jjw24 merged commit 6f2702d into Flow-Launcher:plugin_api_v2 Mar 30, 2025
6 checks passed
@Odotocodot
Copy link
Contributor Author

Just a suggestion, I think instead of hooking into visibility change event, which triggers everytime flow is shown, it might also work just via the query method. If you hook into the event when users each time trigger flow to search then your code to look for the Lively process is ran as well.

Thanks for the heads up. I've moved it to the Query method, with a boolean set in the VisbilityChanged event.
Also, thanks for the merge 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants