New plugin: volcano translation #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibere
requested changes
Mar 31, 2025
Contributor
cibere
left a comment
cibere
left a comment
There was a problem hiding this comment.
Hi, thanks for the plugin submission. However, there are a couple of changes that I'd like you to make.
First of all, could you please add the ability to configure your plugin's settings through flow's settings system?
Here is a link for creating the settings template: https://www.flowlauncher.com/docs/#/json-rpc-settings
As for getting the settings, they are included in the payload that flow sends to your plugin.
plugins/Volcano Translation-0055A981-5039-0D25-6B7D-1312A7CB0F26.json
Outdated
Show resolved
Hide resolved
plugins/Volcano Translation-0055A981-5039-0D25-6B7D-1312A7CB0F26.json
Outdated
Show resolved
Hide resolved
plugins/Volcano Translation-0055A981-5039-0D25-6B7D-1312A7CB0F26.json
Outdated
Show resolved
Hide resolved
wangzmg
commented
Apr 2, 2025
Contributor
Author
wangzmg
left a comment
wangzmg
left a comment
There was a problem hiding this comment.
Improved, please check, thank you
cibere
approved these changes
Apr 2, 2025
Jack251970
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a translation plug-in for Chinese-English translation.
Source: https://github.com/wangzmg/Flow.Launcher.VolcanoTranslation