Skip to content

Conversation

@wangzmg
Copy link
Contributor

@wangzmg wangzmg commented Mar 31, 2025

This is a translation plug-in for Chinese-English translation.
Source: https://github.com/wangzmg/Flow.Launcher.VolcanoTranslation

@wangzmg wangzmg changed the title add volcano translation New plugin: volcano translation Mar 31, 2025
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the plugin submission. However, there are a couple of changes that I'd like you to make.

First of all, could you please add the ability to configure your plugin's settings through flow's settings system?

Here is a link for creating the settings template: https://www.flowlauncher.com/docs/#/json-rpc-settings
As for getting the settings, they are included in the payload that flow sends to your plugin.

Copy link
Contributor Author

@wangzmg wangzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved, please check, thank you

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. Everything looks good to me, however before this gets merged, I'm going to see if another team member is able to test your plugin since I don't speak Chinese.

@cibere cibere requested review from Jack251970 and taooceros April 2, 2025 17:18
@cibere cibere merged commit 2c13f53 into Flow-Launcher:plugin_api_v2 Apr 3, 2025
6 checks passed
@wangzmg wangzmg deleted the add_volcano_translation branch April 3, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants