Skip to content

Conversation

@SweedXD
Copy link
Contributor

@SweedXD SweedXD commented Aug 6, 2025

Updated CurrencyPP (Settings UI Fixed) Flow Launcher Plugin

✨ What's New in This Fork

This version addresses the most critical bug preventing users from configuring the plugin.

  • Fixed Broken Settings UI: The main achievement of this fork is a completely repaired settings page. All configuration options (API Key, default currencies, aliases, etc.) are now fully visible and editable within the Flow Launcher settings window.

🔄 Restart Required: Right-click the Flow Launcher tray icon, choose Exit, and reopen the app for changes to take effect.

SweedXD added 3 commits August 5, 2025 23:20
*   **Simplified Main Menu:** The main `tr` command now shows a clean 3-item menu, making it easier to configure.
*   **Two Ways to Set Your Default Language:**
    *   **Instant Click:** View all **100+ supported languages** with `tr list` and click any language to change your default instantly.
    *   **Command with Confirmation:** Use `tr set <code>` for any language. This includes a confirmation step to prevent accidental changes.
*   **Better Error Handling:** Get clear messages for network timeouts (SSL errors) or invalid language codes.
*   **"No Change" Notifications:** The plugin now correctly informs you when the source text is already in the target language (e.g., trying to translate "bonjour" to French), preventing confusion.
Introduces plugin/settings_manager.py for managing user language preferences and settings. Updates translation logic in plugin/ui.py to support auto-detection, default language, and interactive language selection. Updates .env and user_settings.ini to support configurable default target language. Removes unused files and updates documentation and metadata for version 2.1.0.
@prlabeler prlabeler bot added the enhancement New feature or request label Aug 6, 2025
SweedXD added 2 commits August 7, 2025 01:08
This version addresses the most critical bug preventing users from configuring the plugin.

*   ✅ **Fixed Broken Settings UI:** The main achievement of this fork is a completely repaired settings page. All configuration options (API Key, default currencies, aliases, etc.) are now fully visible and editable within the Flow Launcher settings window.
> 🔄 **Restart Required:** Right-click the Flow Launcher tray icon, choose **Exit**, and reopen the app for changes to take effect.
@prlabeler prlabeler bot added bug Something isn't working Plugin Submission labels Aug 7, 2025
@SweedXD SweedXD changed the title Updated (Enhanced) Direct Translate Flow Launcher Plugin Updated (Enhanced) Direct Translate & CurrencyPP (Settings UI Fixed) Flow Launcher Plugins Aug 7, 2025
@SweedXD SweedXD changed the title Updated (Enhanced) Direct Translate & CurrencyPP (Settings UI Fixed) Flow Launcher Plugins Updated Direct Translate (Enhanced) & CurrencyPP (Settings UI Fixed) Flow Launcher Plugins Aug 7, 2025
@cibere
Copy link
Contributor

cibere commented Aug 11, 2025

As far as the direct translate plugin is concerned, the version of it that is currently on the manifest is actually a fork of the original as well: https://github.com/deefrawley/Flow.Launcher.Plugin.DirectTranslate
Unless you have a reason to do so otherwise, please contribute to this fork instead of submitting a new fork of it to the manifest.

@cibere cibere removed bug Something isn't working enhancement New feature or request labels Aug 11, 2025
@SweedXD
Copy link
Contributor Author

SweedXD commented Aug 11, 2025

Ok, no problem. I've reverted it and submitted a PR.

@prlabeler prlabeler bot added the bug Something isn't working label Aug 11, 2025
@SweedXD SweedXD changed the title Updated Direct Translate (Enhanced) & CurrencyPP (Settings UI Fixed) Flow Launcher Plugins Updated CurrencyPP (Settings UI Fixed) Flow Launcher Plugin Aug 11, 2025
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this file so that it is a valid json file

@cibere cibere removed the bug Something isn't working label Aug 12, 2025
@cibere
Copy link
Contributor

cibere commented Aug 12, 2025

If you don't mind, please change the plugin's name to just CurrencyPP, as the original one will most likely be taken off of the manifest via #544.

@SweedXD SweedXD requested a review from cibere August 12, 2025 11:03
@SweedXD
Copy link
Contributor Author

SweedXD commented Aug 12, 2025

Done

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please use the github action to create and package the release version of the plugin.
  2. The plugin's name is still set as CurrencyPP (UI Fixed) in its plugin.json file

@SweedXD
Copy link
Contributor Author

SweedXD commented Aug 12, 2025

Sorry for bothering you, I'm new to this.
I updated the plugin.json file.
Now what should I do, I didn't update the Release yet

@cibere
Copy link
Contributor

cibere commented Aug 12, 2025

Sorry for bothering you, I'm new to this. I updated the plugin.json file. Now what should I do, I didn't update the Release yet

For releases, we require the plugin itself to be built and published by a github action. The previous developer of CurrencyPP setup this workflow to do just that, so you should be able to just re-use the same one. Though, to me at least, it appears that github doesn't recognize the workflow. I don't remember the "correct" way to fix this, however I believe pushing a commit to delete it, then another commit to re-create it should work. As far as how to use the workflow, it appears to have two triggers:

on:
  workflow_dispatch:
  push:
    branches: [ master ]

workflow_dispatch lets you manually trigger the workflow via the actions tab in the repository, and push makes the workflow automatically run upon receiving a commit. So, simply ensuring that github recognizes the workflow should be enough to get it to properly trigger.

@SweedXD SweedXD requested a review from cibere August 12, 2025 19:53
@SweedXD
Copy link
Contributor Author

SweedXD commented Aug 12, 2025

Using your provided information and some AI, I think it is now fixed. Thank you

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine now, thanks for making all of those changes.

@cibere cibere merged commit 0144838 into Flow-Launcher:plugin_api_v2 Aug 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants