-
Notifications
You must be signed in to change notification settings - Fork 161
Updated CurrencyPP (Settings UI Fixed) Flow Launcher Plugin #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* **Simplified Main Menu:** The main `tr` command now shows a clean 3-item menu, making it easier to configure.
* **Two Ways to Set Your Default Language:**
* **Instant Click:** View all **100+ supported languages** with `tr list` and click any language to change your default instantly.
* **Command with Confirmation:** Use `tr set <code>` for any language. This includes a confirmation step to prevent accidental changes.
* **Better Error Handling:** Get clear messages for network timeouts (SSL errors) or invalid language codes.
* **"No Change" Notifications:** The plugin now correctly informs you when the source text is already in the target language (e.g., trying to translate "bonjour" to French), preventing confusion.
Introduces plugin/settings_manager.py for managing user language preferences and settings. Updates translation logic in plugin/ui.py to support auto-detection, default language, and interactive language selection. Updates .env and user_settings.ini to support configurable default target language. Removes unused files and updates documentation and metadata for version 2.1.0.
This reverts commit 356f651.
This version addresses the most critical bug preventing users from configuring the plugin. * ✅ **Fixed Broken Settings UI:** The main achievement of this fork is a completely repaired settings page. All configuration options (API Key, default currencies, aliases, etc.) are now fully visible and editable within the Flow Launcher settings window. > 🔄 **Restart Required:** Right-click the Flow Launcher tray icon, choose **Exit**, and reopen the app for changes to take effect.
|
As far as the direct translate plugin is concerned, the version of it that is currently on the manifest is actually a fork of the original as well: https://github.com/deefrawley/Flow.Launcher.Plugin.DirectTranslate |
|
Ok, no problem. I've reverted it and submitted a PR. |
cibere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this file so that it is a valid json file
|
If you don't mind, please change the plugin's name to just |
|
Done |
cibere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please use the github action to create and package the release version of the plugin.
- The plugin's name is still set as
CurrencyPP (UI Fixed)in itsplugin.jsonfile
|
Sorry for bothering you, I'm new to this. |
For releases, we require the plugin itself to be built and published by a github action. The previous developer of CurrencyPP setup this workflow to do just that, so you should be able to just re-use the same one. Though, to me at least, it appears that github doesn't recognize the workflow. I don't remember the "correct" way to fix this, however I believe pushing a commit to delete it, then another commit to re-create it should work. As far as how to use the workflow, it appears to have two triggers:
|
|
Using your provided information and some AI, I think it is now fixed. Thank you |
cibere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine now, thanks for making all of those changes.
Updated CurrencyPP (Settings UI Fixed) Flow Launcher Plugin
✨ What's New in This Fork
This version addresses the most critical bug preventing users from configuring the plugin.