Addressing more warnings

Author: nachmore

Flow.Launcher.Core/Flow.Launcher.Core.csproj

@@ -56,7 +56,7 @@
     <PackageReference Include="Droplex" Version="1.4.1" />
     <PackageReference Include="FSharp.Core" Version="5.0.2" />
     <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="2.1.3" />
-    <PackageReference Include="squirrel.windows" Version="1.5.2" />
+    <PackageReference Include="squirrel.windows" Version="1.5.2" NoWarn="NU1701" />
   </ItemGroup>
 
   <ItemGroup>

Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs

@@ -69,7 +69,7 @@ public List<Result> LoadContextMenus(Result selectedResult)
         private static readonly JsonSerializerOptions options = new()
         {
             PropertyNameCaseInsensitive = true,
-            IgnoreNullValues = true,
+            DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull,
             Converters =
             {
                 new JsonObjectConverter()
@@ -535,4 +535,4 @@ public void UpdateSettings(Dictionary<string, object> settings)
             }
         }
     }
-}
+}

Flow.Launcher.Plugin/Result.cs

@@ -1,12 +1,14 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Threading.Tasks;
 using System.Windows.Media;
 
 namespace Flow.Launcher.Plugin
 {
-
+    /// <summary>
+    /// Describes the result of a plugin
+    /// </summary>
     public class Result
     {
 
@@ -65,6 +67,10 @@ public string IcoPath
             }
         }
 
+        /// <summary>
+        /// Delegate function, see <see cref="Icon"/>
+        /// </summary>
+        /// <returns></returns>
         public delegate ImageSource IconDelegate();
 
         /// <summary>
@@ -105,6 +111,9 @@ public string IcoPath
         /// </summary>
         public IList<int> TitleHighlightData { get; set; }
 
+        /// <summary>
+        /// Deprecated as of Flow Launcher v1.9.1. Subtitle highlighting is no longer offered
+        /// </summary>
         [Obsolete("Deprecated as of Flow Launcher v1.9.1. Subtitle highlighting is no longer offered")]
         public IList<int> SubTitleHighlightData { get; set; }
 
@@ -178,10 +187,15 @@ public override string ToString()
         /// Show message as ToolTip on result SubTitle hover over
         /// </summary>
         public string SubTitleToolTip { get; set; }
-    
+
+        /// <summary>
+        /// Run this result, asynchronously
+        /// </summary>
+        /// <param name="context"></param>
+        /// <returns></returns>
         public ValueTask<bool> ExecuteAsync(ActionContext context)
         {
             return AsyncAction?.Invoke(context) ?? ValueTask.FromResult(Action?.Invoke(context) ?? false);
         }
     }
-}
+}

Plugins/Flow.Launcher.Plugin.Shell/Flow.Launcher.Plugin.Shell.csproj

@@ -61,7 +61,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="InputSimulator" Version="1.0.4" />
+    <PackageReference Include="InputSimulator" Version="1.0.4" NoWarn="NU1701" />
   </ItemGroup>
 
 </Project>