Fix plugin install issue

Jack251970 · Jack251970 · commit c907c291480a · 2025-01-05T21:16:49.000+08:00
diff --git a/Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs b/Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs
@@ -197,20 +197,22 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                             prgBox.Close();
                             prgBox = null;
                         });
-
-                        Install(plugin, filePath);
                     }
                     else
                     {
                         await Http.DownloadAsync(plugin.UrlDownload, filePath).ConfigureAwait(false);
-                        Install(plugin, filePath);
                     }
                 }
                 else
                 {
                     filePath = plugin.LocalInstallPath;
-                    Install(plugin, filePath);
                 }
+
+                // check if user cancelled download before installing plugin
+                if (downloadCancelled)
+                    return;
+
+                Install(plugin, filePath);
             }
             catch (HttpRequestException e)
             {

Original file line number	Diff line number	Diff line change
`@@ -197,20 +197,22 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)`
`197`	`197`	`prgBox.Close();`
`198`	`198`	`prgBox = null;`
`199`	`199`	`});`
`200`		`-`
`201`		`- Install(plugin, filePath);`
`202`	`200`	`}`
`203`	`201`	`else`
`204`	`202`	`{`
`205`	`203`	`await Http.DownloadAsync(plugin.UrlDownload, filePath).ConfigureAwait(false);`
`206`		`- Install(plugin, filePath);`
`207`	`204`	`}`
`208`	`205`	`}`
`209`	`206`	`else`
`210`	`207`	`{`
`211`	`208`	`filePath = plugin.LocalInstallPath;`
`212`		`- Install(plugin, filePath);`
`213`	`209`	`}`
	`210`	`+`
	`211`	`+ // check if user cancelled download before installing plugin`
	`212`	`+ if (downloadCancelled)`
	`213`	`+ return;`
	`214`	`+`
	`215`	`+ Install(plugin, filePath);`
`214`	`216`	`}`
`215`	`217`	`catch (HttpRequestException e)`
`216`	`218`	`{`