Change usage of Http in Updater.cs and adding ConfigureAwait(false) for await in checking update

Author: taooceros

Flow.Launcher.Core/Updater.cs

@@ -29,7 +29,7 @@ public Updater(string gitHubRepository)
             GitHubRepository = gitHubRepository;
         }
 
-        public async Task UpdateApp(IPublicAPI api , bool silentUpdate = true)
+        public async Task UpdateApp(IPublicAPI api, bool silentUpdate = true)
         {
             UpdateManager updateManager;
             UpdateInfo newUpdateInfo;
@@ -39,7 +39,7 @@ public async Task UpdateApp(IPublicAPI api , bool silentUpdate = true)
 
             try
             {
-                updateManager = await GitHubUpdateManager(GitHubRepository);
+                updateManager = await GitHubUpdateManager(GitHubRepository).ConfigureAwait(false);
             }
             catch (Exception e) when (e is HttpRequestException || e is WebException || e is SocketException)
             {
@@ -50,7 +50,7 @@ public async Task UpdateApp(IPublicAPI api , bool silentUpdate = true)
             try
             {
                 // UpdateApp CheckForUpdate will return value only if the app is squirrel installed
-                newUpdateInfo = await updateManager.CheckForUpdate().NonNull();
+                newUpdateInfo = await updateManager.CheckForUpdate().NonNull().ConfigureAwait(false);
             }
             catch (Exception e) when (e is HttpRequestException || e is WebException || e is SocketException)
             {
@@ -85,8 +85,8 @@ public async Task UpdateApp(IPublicAPI api , bool silentUpdate = true)
                 updateManager.Dispose();
                 return;
             }
-            
-            await updateManager.ApplyReleases(newUpdateInfo);
+
+            await updateManager.ApplyReleases(newUpdateInfo).ConfigureAwait(false);
 
             if (DataLocation.PortableDataLocationInUse())
             {
@@ -98,11 +98,11 @@ public async Task UpdateApp(IPublicAPI api , bool silentUpdate = true)
             }
             else
             {
-                await updateManager.CreateUninstallerRegistryEntry();
+                await updateManager.CreateUninstallerRegistryEntry().ConfigureAwait(false);
             }
 
             var newVersionTips = NewVersinoTips(newReleaseVersion.ToString());
-            
+
             Log.Info($"|Updater.UpdateApp|Update success:{newVersionTips}");
 
             // always dispose UpdateManager
@@ -133,9 +133,9 @@ private async Task<UpdateManager> GitHubUpdateManager(string repository)
             var uri = new Uri(repository);
             var api = $"https://api.github.com/repos{uri.AbsolutePath}/releases";
 
-            var json = await Http.GetAsync(api);
+            var jsonStream = await Http.GetStreamAsync(api).ConfigureAwait(false);
 
-            var releases = JsonConvert.DeserializeObject<List<GithubRelease>>(json);
+            var releases = await System.Text.Json.JsonSerializer.DeserializeAsync<List<GithubRelease>>(jsonStream).ConfigureAwait(false);
             var latest = releases.Where(r => !r.Prerelease).OrderByDescending(r => r.PublishedAt).First();
             var latestUrl = latest.HtmlUrl.Replace("/tag/", "/download/");