Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Feb 8, 2022

Goal:
Allow plugins to capture hotkey presses on query window results, such as Ctrl+P, F1, Space, Ctrl+Backspace, Up or Down.

This information is then passed onto each plugin, which will allow them to do some action based on the hotkey and information supplied.

This is a proof of concept PR, using F1 key press as an example to demonstrate when F1 is pressed on a result, the information of the selected result is translated to a path which is then passed onto each plugin. Only if the plugin inherits IPathSelected, will it be able to capture and use the path and hotkey information to do something further.
This example uses Explorer plugin, and works with JsonRPC plugins (i.e. Python, TS, JS and etc).

What success looks like:

  1. Allow plugin to utilise QuickLook from Open selected result in quicklook #859 and previews should work on Up, Down or F1 hotkeys on the selected result.
  2. Allow Explorer or Everything plugin to utilise Ctrl+C on a selected result that is a file/folder and have it copied on to clipboard.
  3. JsonRPC plugins to also utilise the new feature.

@jjw24 jjw24 self-assigned this Feb 8, 2022
@github-actions github-actions bot added the Stale label May 19, 2022
@jjw24 jjw24 marked this pull request as draft September 7, 2023 22:29
@jjw24
Copy link
Member Author

jjw24 commented Sep 7, 2023

@taooceros please have a look at this concept when you can. This will allow any plugin to use hotkeys not just the default ones. Feeds into the Quicklook work.

@jjw24
Copy link
Member Author

jjw24 commented May 28, 2024

On second thought, not feasible to map hotkeys ongoing. Better to allow plugin support via functionality, i.e. for external preview support with a QuickLook plugin design 666211d (#2082).

Closing.

@jjw24 jjw24 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Copy file/folder path: built-in hotkey ctrl-shift-c and remove notification.

1 participant