Bump ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0 #1835
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [ToolGood.Words.Pinyin](https://github.com/toolgood/ToolGood.Words.Pinyin) from 3.0.1.4 to 3.1.0. - [Release notes](https://github.com/toolgood/ToolGood.Words.Pinyin/releases) - [Commits](https://github.com/toolgood/ToolGood.Words.Pinyin/commits) --- updated-dependencies: - dependency-name: ToolGood.Words.Pinyin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
.NET
This comment has been minimized.
This comment has been minimized.
|
It does introduce a significant memory usage. Although I think it is acceptable, since that will only apply to people who uses pinyin (and it does provide better pinyin). |
|
|
around 100M I don't really know what exactly more pinyin is provided. Probably check the commit history? toolgood/ToolGood.Words.Pinyin@dcf03a4 |
|
I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think? |
well sure |
|
Just converting this to draft until we actually need to bump it. |
|
Continue in #3846 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)