Skip to content

Add external preview (QuickLook) support #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jun 16, 2024
Merged

Add external preview (QuickLook) support #2082

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
71376b8
Add FilePath property for PreviewInfo
VictoriousRaptor Apr 21, 2023
96f5231
Add FilePath for Explorer results preview
VictoriousRaptor Apr 21, 2023
0c4f50a
Default values for preview info
VictoriousRaptor Apr 21, 2023
1cedb6e
Add file path in preview
VictoriousRaptor Apr 21, 2023
f460913
Move QuickLook support to QuickLookHelper
VictoriousRaptor Apr 22, 2023
0b6f737
Add open/close QuickLook function
VictoriousRaptor Apr 22, 2023
ab20dcc
Reorganize preview code
VictoriousRaptor Apr 22, 2023
98991fe
Implement open QuickLook feature
VictoriousRaptor Apr 22, 2023
99b5197
Fix case when switching file
VictoriousRaptor Apr 22, 2023
1e1f29b
Add UI to toggle QuickLook usage
VictoriousRaptor Apr 22, 2023
afa8a34
Tweak Win32 preview path
VictoriousRaptor Apr 22, 2023
a1600fa
Implement preview switching logic
VictoriousRaptor Apr 22, 2023
cf10a4a
Rename method for clarity
VictoriousRaptor Apr 22, 2023
10d1410
Reduce unnecessary image load
VictoriousRaptor Apr 22, 2023
ba8bb3a
Fix switching preview logic
VictoriousRaptor Apr 22, 2023
098e90b
Hide external preview when hiding flow
VictoriousRaptor Apr 22, 2023
26ff98e
comment
VictoriousRaptor Apr 22, 2023
9061da9
Formatting
VictoriousRaptor Apr 23, 2023
441d4cb
Configure await for QuickLook calls
VictoriousRaptor Apr 23, 2023
45a42a5
Log exception when QL timeout
VictoriousRaptor Apr 23, 2023
cda587f
Show toast when QL unavailable
VictoriousRaptor Apr 23, 2023
2ed33a2
Refactor QuickLook toggle and update logic
VictoriousRaptor May 13, 2023
64afeed
Rename variable
VictoriousRaptor May 13, 2023
d266e9e
Simplify QuickLook logic
VictoriousRaptor May 20, 2023
ff7457d
Keep FL open when focus lost if QL open
VictoriousRaptor May 20, 2023
cb33756
Remove QL support for programs
VictoriousRaptor May 20, 2023
abfbef4
update
VictoriousRaptor May 20, 2023
c705b01
Change glyph
VictoriousRaptor May 22, 2023
7033bce
Add minimum gap time between fail toasts
VictoriousRaptor May 22, 2023
2bb398d
Add sendFailToast arg
VictoriousRaptor Jul 11, 2023
1eae693
Merge branch 'dev' into quicklook
VictoriousRaptor Jul 11, 2023
e248fcb
Fix build error introduced in 1eae69304f3f961b70fe224a58d870d85bcb08ad
VictoriousRaptor Jul 11, 2023
8da88bd
Hide fail toast for closing
VictoriousRaptor Aug 5, 2023
c36cea7
Merge branch 'dev' into quicklook
VictoriousRaptor Aug 27, 2023
29c1503
Merge branch 'dev' into quicklook
VictoriousRaptor Oct 15, 2023
666211d
add plugin support for external preview
jjw24 May 28, 2024
8da1313
update external preview methods to use the external preview interface
jjw24 May 28, 2024
587536f
updated PreviewVisible logic to base on ResultAreaColumn size
jjw24 May 28, 2024
53e4bbb
updated internal and external preview's show and hide logic
jjw24 May 28, 2024
b345944
Merge branch 'external_preview_plugin_support' into quicklook
jjw24 May 28, 2024
70e530b
add QuickLook plugin for testing
jjw24 May 29, 2024
493a30e
remove QuickLook related code from flow
jjw24 May 29, 2024
f902eae
Merge remote-tracking branch 'origin/dev' into quicklook
jjw24 May 29, 2024
9e39e48
minor clean up and update
jjw24 May 30, 2024
f4f519b
minor clean up
jjw24 May 31, 2024
5ec474c
Merge branch 'dev' into quicklook
VictoriousRaptor Jun 1, 2024
2e47da4
allow internal preview when external not available
jjw24 Jun 6, 2024
e6f0f28
Don't show external preview when always preview enabled
VictoriousRaptor Jun 9, 2024
4dbecb1
allow preview plugin to override the AlwaysPreview setting
jjw24 Jun 12, 2024
03686dd
Merge remote-tracking branch 'origin/dev' into quicklook
jjw24 Jun 12, 2024
0c0806e
Merge branch 'dev' into quicklook
jjw24 Jun 15, 2024
25963ea
Merge branch 'dev' into quicklook
jjw24 Jun 16, 2024
7f31fef
remove QuickLook plugin test project
jjw24 Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Flow.Launcher/ViewModel/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
Expand Down Expand Up @@ -871,7 +871,7 @@ public void ResetPreview()
{
if (Settings.AlwaysPreview)
{
ShowPreview();
ShowInternalPreview();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When AlwaysPreview is true, specify internal preview.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because QL is not suitable for using with always preview right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because QL is not suitable for using with always preview right?

Yep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when we have other preview tools that is suitable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when we have other preview tools that is suitable?

Well maybe pass always preview to plugin and let plugin decide? If plugin returns false then use internal preview.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Let me know if good to merge.

}
else
{
Expand Down