Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented May 16, 2024

What's the PR

Test Cases

  • If the animation is on and the mouse is moved while the animation is running, the mouse hover is not work.
  • In a situation with many results, hover should not work when the mouse is moved while holding down the up or down arrow key.

@onesounds onesounds added the bug Something isn't working label May 16, 2024
@onesounds onesounds self-assigned this May 16, 2024
switch (e.Key)
{
case Key.Down:
isArrowKeyPressed = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick test and found that holding Next Result hotkey also has this issue. IMO we should just left it. hard to fix for every hotkey.

Copy link
Contributor Author

@onesounds onesounds May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. Basically, the user mainly uses the single key, but the shortcut key that combines the two will not be used. (Pressing key situation) I think we can ignore other than this key.
+)And I tried logic to block any keyboard when I was just pressing it, but it didn't work out.

@jjw24 jjw24 added this to the 1.19.0 milestone May 17, 2024
@jjw24 jjw24 merged commit b9b3422 into Flow-Launcher:dev May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When search window appears mouse cursor is triggered to highlight result where the cursor is positioned

3 participants