Skip to content

Real-time updates to ComboBox localization in general pane of settings after changing the language #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

Real-time updates to ComboBox localization in general pane of settings after changing the language #2732

merged 1 commit into from
May 28, 2024

Conversation

@Yusyuriv
Copy link
Member

Changes

  • Comboboxes in Settings — General now reflect the language change immediately
  • Query search precision ComboBox is now also localized

Testing

  • Comboboxes work correctly
  • Settings.json gets saved with correct data from comboboxes

@Yusyuriv Yusyuriv added bug Something isn't working kind/i18n labels May 27, 2024
@Yusyuriv Yusyuriv requested review from onesounds and taooceros May 27, 2024 22:46
@Yusyuriv Yusyuriv self-assigned this May 27, 2024
@onesounds onesounds mentioned this pull request May 28, 2024
Closed
@onesounds onesounds merged commit 3d1434f into dev May 28, 2024
@onesounds onesounds deleted the settings-comboboxes-realtime-localization branch May 28, 2024 01:03
@jjw24 jjw24 added this to the 1.19.0 milestone Jun 23, 2024
@jjw24 jjw24 mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onesounds onesounds onesounds approved these changes

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@Yusyuriv Yusyuriv

Labels

bug Something isn't working kind/i18n

Projects

None yet

Milestone

1.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Yusyuriv @onesounds @jjw24