Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented May 28, 2024

Review Guide

  • You can review it in 20 minutes or less.
  • This PR is mostly a design fix. but Added a topic about theme properties.
  • This is a PR that requires a decision about deleting an existing theme and how to do it.

What's the PR

  • Removed duplicate themes that can be selected by colorscheme (win11light, win11dark, circle system, etc)
    • win10light is removed, and the existing win11style becomes win10style.
    • The bullet theme will be changed to system and become windows11 style. This is now the default.
  • The default theme value will remain win11light, but the actual interior will contain two types of light/dark, like system.
    • To avoid confusing users, we've labeled the system type with a small icon. Added a setting for individual names separate from filenames. circle means "support color scheme", drop means "support blur"
  • Theme designer can indicate separate names / blur / dark via comments in xaml. if not exist, If it doesn't exist, it will behave the old way.
  • Adjusting the alignment differences caused by the ability to adjust the sizes.
  • Changed the theme picker to an expandable card.

image

  • Fixed an issue that caused a small space to appear on the left side of the preview resizer. This can be seen with previews of themes with full width selection.

Before
image

After
image

Theme Editor Size Up

  • In theme edit mode, the vertical size increases.

Details

  • Modify all items that are glyph color weird
  • Modified all the themes that felt a little strange because the glyph color was different from the font color.
  • Change searchbox text to center from slightly below
    • As users are able to adjust the window size and font size, they troubleshoot problems that may look a little strange when the size changes.
  • Fix Accent color of circle system.
    • All the accent colors follow the colors set in the system.
  • Removed the win type themed high light color. Apply semi-bold only.
    • This is the Windows standard form, and it removes the phenomenon I personally call "COLOR RAIN".
  • Adjust Preview margins.

Test Cases

  • Each theme should come out beautifully.
  • For themes with tightly packed selections, there should be no visible white space on the right side when the preview is open.
  • The resizing of the preview area should work properly.

@onesounds onesounds self-assigned this May 28, 2024
@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label May 28, 2024
@onesounds onesounds marked this pull request as draft May 28, 2024 11:00
@onesounds onesounds marked this pull request as ready for review May 31, 2024 00:55
@taooceros taooceros enabled auto-merge June 7, 2024 22:35
@taooceros taooceros merged commit bd14aa4 into Flow-Launcher:dev Jun 7, 2024
@jjw24 jjw24 added the bug Something isn't working label Jun 24, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/ui related to UI, icons, themes, etc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants