Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented May 30, 2024

What's the PR

  • Fix BUG: F1 preview of images does not fill the whole preview area #2030
  • The image appears full in the preview pane.
  • Vertically long images are prioritized to be vertically full.
  • Specify the minimum height in the preview area for too few results
  • Fix a problem where the screen center separator appears later than the result
  • Fix the color of the separator in the explorer plugin's preview panel.
  • Fixing a problem where the number of results is adjusted by triggering resize when the window is moved or the width is adjusted.
  • When preview is on and there are enough results, temporarily adjust the number of results to fit the preview minimum height. When preview is off, change it back to the existing number of results.
    • If the number of results is very small, we'll just leave it blank.

Test Cases

  • The color of the preview separator must be the same as the bottom separator of the search window, and there must be no binding errors.
  • The image should be displayed as horizontally or vertically as possible as the size of the preview area.
  • When the preview is turned on with the minimum number of results, the number of results should not change if the window is moved or the width is adjusted.
  • If you turn on previw when the maximum number of results to display is low, it temporarily adjusts the number by the size of the preview.

@taooceros
Copy link
Member

Vertically long images are prioritized to be vertically full.

What does this mean? I think on dev it is vertically full?

@onesounds
Copy link
Contributor Author

onesounds commented May 30, 2024

Vertically long images are prioritized to be vertically full.

What does this mean? I think on dev it is vertically full?

  • Long vertically images fill the vertical area first. (that is, there is a margin on the left and right)
  • Conversely, the horizontal long image is filled first, and there is a margin at the top and bottom.
  • I don't remember what the current dev state is like. In dev, the transverse is certainly not filled within the preview area, and it is a part adjusted for this change.

@onesounds onesounds self-assigned this May 31, 2024
@Yusyuriv
Copy link
Member

I just noticed that if an image is too small, it still gets scaled up to fill all available space. Is that okay?

@onesounds onesounds merged commit 8972d9e into Flow-Launcher:dev May 31, 2024
@jjw24 jjw24 added the bug Something isn't working label Jul 5, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: F1 preview of images does not fill the whole preview area

4 participants