Add function to validate previous Window position

[z1nc0r3]

• A new function was added to check whether the previously saved Window position is still valid or not. If not it resets the Window position to default.
• Fixes BUG: FL Settings Window breaks on multi-monitor setup #2847

[coderabbitai]

Walkthrough

Walkthrough

The InitializePosition method in SettingWindow.xaml.cs has been enhanced to handle multi-monitor setups more effectively. It now checks if the saved window position is valid using a new private method, IsPositionValid, before setting the window position. This ensures the window appears on a currently connected monitor, preventing issues when a monitor is disconnected.

Changes

Files	Change Summary
Flow.Launcher/SettingWindow.xaml.cs	Added the IsPositionValid method to validate window positions against screen boundaries. Updated InitializePosition to use this validation and local variables for readability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingWindow
    participant Screen

    User ->> SettingWindow: Open Settings Window
    SettingWindow ->> SettingWindow: InitializePosition
    SettingWindow ->> Screen: Get screens
    SettingWindow ->> SettingWindow: IsPositionValid
    alt Position Valid
        SettingWindow ->> SettingWindow: Set position
    else Position Invalid
        SettingWindow ->> SettingWindow: Use default position
    end
    SettingWindow ->> User: Settings Window displayed

Loading

Assessment against linked issues

Objective (Issue #2847)	Addressed	Explanation
Check if the window position is valid	✅
Handle window positions when secondary monitor is disconnected	✅

Poem

Amidst the screens, the windows flow,
To find their place where pixels glow.
A code to check, a path to see,
Ensures the settings window's free.
No monitor left out or lost,
A seamless dance, no matter the cost.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

Flow.Launcher/SettingWindow.xaml.cs (1)

113-115: Use null-coalescing assignment for better readability.

The variables previousTop and previousLeft can be initialized using null-coalescing assignment for better readability.

-  var previousTop = _settings.SettingWindowTop;
-  var previousLeft = _settings.SettingWindowLeft;
+  var previousTop = _settings.SettingWindowTop ?? WindowTop();
+  var previousLeft = _settings.SettingWindowLeft ?? WindowLeft();

[gitstream-cm]

🥷 Code experts: Yusyuriv, onesounds

Yusyuriv, onesounds have most 👩‍💻 activity in the files.
Yusyuriv, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingWindow.xaml.cs

Activity based on git-commit:

	Yusyuriv	onesounds
JUL
JUN		34 additions & 34 deletions
MAY	132 additions & 501 deletions	9 additions & 9 deletions
APR	22 additions & 43 deletions	115 additions & 91 deletions
MAR
FEB

Knowledge based on git-blame:
Yusyuriv: 65%
onesounds: 14%

To learn more about /:\ gitStream - Visit our Docs