Pass MaxResult setting to EverythingApi

[Ishmaeel]

MaxResult value in Settings.json was ignored for Everything searches. Pass the value to EverythingApi for all searches.

Fixes #2873.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to the Explorer plugin enhance its search functionality by allowing users to specify a maximum number of search results. The introduction of a MaxCount parameter in the EverythingSearchOption constructor addresses a previous limitation of hardcoded results, improving both performance and user experience.

Changes

Files	Change Summary
Plugins/.../EverythingSearchManager.cs, Plugins/.../EverythingSearchOption.cs	Updated EverythingSearchOption instantiation to include MaxCount in the constructor.
Plugins/.../SettingsViewModel.cs	Added MaxResult property with clamping functionality.
Plugins/.../Flow.Launcher.Plugin.Explorer.csproj	Updated TargetFramework and added ModernWpfUI package reference.
Plugins/.../Languages/en.xaml	Added new string resources for "Maximum results" and its tooltip.
Plugins/.../ExplorerSettings.xaml	Enhanced UI with new input controls for setting maximum results.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Explorer plugin honors MaxResult setting (#2873)	✅

🐇 In the meadow, we hop with glee,
Searching for treasures, wild and free.
With MaxCount now in our sway,
Results are trimmed, hooray, hooray!
No more clutter, just what we seek,
A tidy search, week after week! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[jjw24]

Thanks for the PR 👍

Is it applicable to add a UI so users not have to edit the json file?

[Ishmaeel]

Thanks for the PR 👍

Is it applicable to add a UI so users not have to edit the json file?

I had assumed it was intentionally left as an advanced option, but sure, I'm happy to add one.

[Ishmaeel]

I tried my hand at adding the UI but there might be some questionable choices in the PR, review and feedback appreciated.

Here's the "after":

[z1nc0r3]

since this is Everything related config, what about moving it under Everything Settings?

[Ishmaeel]

since this is Everything related config, what about moving it under Everything Settings?

It's not specific to Everything. The setting itself is implemented for the entire plugin and already in use by Windows Index:

Flow.Launcher/Plugins/Flow.Launcher.Plugin.Explorer/Search/WindowsIndex/QueryConstructor.cs

Line 22 in dd0ae98

baseQuery.QueryMaxResults = settings.MaxResult;

[jjw24]

This PR should be open right.

[Ishmaeel]

This PR should be open right.

Yes, thank you. I must have closed it accidentally when I merged it into my personal branch.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.