Skip to content

Conversation

@Ishmaeel
Copy link
Contributor

@Ishmaeel Ishmaeel commented Aug 10, 2024

Fixes #2882.

Date and Time previews are using CurrentCulture which is incorrect.

In order to use the correct UI culture managed by FlowLauncher, they should be using CurrentUICulture.

Before, with English selected under settings:

image

After, with English selected under settings:

image

After, with Spanish selected under settings:

image

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 10, 2024

Walkthrough

Walkthrough

The recent changes enhance the localization of date and time displays in the SettingsPaneThemeViewModel by switching from CultureInfo.CurrentCulture to CultureInfo.CurrentUICulture. This modification ensures that the date and time formats align more closely with the user's language preferences, thereby improving the overall user experience in diverse cultural contexts.

Changes

Files Change Summary
Flow.Launcher/SettingPages/ViewModels/... Updated ClockText and DateText properties to use CultureInfo.CurrentUICulture for better localization.

Possibly related issues

🐇 In fields so bright, I bounce with delight,
A change for the time, making everything right!
With culture anew, the clocks proudly chime,
In every sweet language, they dance and they rhyme!
Oh, cheerful display, let the dates now align,
A hop and a skip, how lovely to shine! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@prlabeler prlabeler bot added the bug Something isn't working label Aug 10, 2024
@github-actions

This comment has been minimized.

@Ishmaeel Ishmaeel closed this Aug 10, 2024
@Ishmaeel Ishmaeel deleted the ishmaeel_2882 branch August 10, 2024 12:24
@Ishmaeel Ishmaeel restored the ishmaeel_2882 branch August 10, 2024 12:24
@Ishmaeel Ishmaeel reopened this Aug 11, 2024
@github-actions

This comment has been minimized.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor VictoriousRaptor merged commit 59ed2b1 into Flow-Launcher:dev Aug 12, 2024
@Ishmaeel Ishmaeel deleted the ishmaeel_2882 branch August 12, 2024 05:08
@coderabbitai coderabbitai bot mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Clock and Date previews in Settings > Appearance uses wrong locale

3 participants