Skip to content

Fix inputWithFileBtn not working in SettingsTemplate.yml #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix inputWithFileBtn not working in SettingsTemplate.yml #3057

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6604710
Fix `inputWithFileBtn` not working in SettingsTemplate.yml
Yusyuriv Nov 3, 2024
1bdfc30
Add `using` when creating a file/folder dialog
Yusyuriv Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@
using System.Windows;
using System.Windows.Controls;
using System.Windows.Documents;
using System.Windows.Forms;
using Flow.Launcher.Infrastructure.Storage;
using Flow.Launcher.Plugin;
using CheckBox = System.Windows.Controls.CheckBox;
using ComboBox = System.Windows.Controls.ComboBox;
using Control = System.Windows.Controls.Control;
using Orientation = System.Windows.Controls.Orientation;
using TextBox = System.Windows.Controls.TextBox;
using UserControl = System.Windows.Controls.UserControl;

namespace Flow.Launcher.Core.Plugin
{
Expand Down Expand Up @@ -224,6 +231,7 @@ public Control CreateSettingPanel()
break;
}
case "inputWithFileBtn":
case "inputWithFolderBtn":
{
var textBox = new TextBox()
{
Expand All @@ -243,6 +251,24 @@ public Control CreateSettingPanel()
Margin = new Thickness(10, 0, 0, 0), Content = "Browse"
};

Btn.Click += (_, _) =>
{
CommonDialog dialog = type switch
{
"inputWithFolderBtn" => new FolderBrowserDialog(),
_ => new OpenFileDialog(),
};
if (dialog.ShowDialog() != DialogResult.OK) return;

var path = dialog switch
{
FolderBrowserDialog folderDialog => folderDialog.SelectedPath,
OpenFileDialog fileDialog => fileDialog.FileName,
};
textBox.Text = path;
Settings[attribute.Name] = path;
};

var dockPanel = new DockPanel() { Margin = settingControlMargin };

DockPanel.SetDock(Btn, Dock.Right);
Expand Down
Loading