Skip to content

do not try catch the error for jsonrpc v2 #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

do not try catch the error for jsonrpc v2 #3190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d21b936
do not try catch the error for jsonrpc v2
taooceros Jan 20, 2025
0beb0b3
Merge branch 'dev' into jsonrpc-v2-error
taooceros Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 12 additions & 33 deletions Flow.Launcher.Core/Plugin/JsonRPCPluginV2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,54 +26,33 @@ internal abstract class JsonRPCPluginV2 : JsonRPCPluginBase, IAsyncDisposable, I

protected override async Task<bool> ExecuteResultAsync(JsonRPCResult result)
{
try
{
var res = await RPC.InvokeAsync<JsonRPCExecuteResponse>(result.JsonRPCAction.Method,
argument: result.JsonRPCAction.Parameters);
var res = await RPC.InvokeAsync<JsonRPCExecuteResponse>(result.JsonRPCAction.Method,
argument: result.JsonRPCAction.Parameters);

return res.Hide;
}
catch
{
return false;
}
return res.Hide;
}

private JoinableTaskFactory JTF { get; } = new JoinableTaskFactory(new JoinableTaskContext());

public override List<Result> LoadContextMenus(Result selectedResult)
{
try
{
var res = JTF.Run(() => RPC.InvokeWithCancellationAsync<JsonRPCQueryResponseModel>("context_menu",
new object[] { selectedResult.ContextData }));
var res = JTF.Run(() => RPC.InvokeWithCancellationAsync<JsonRPCQueryResponseModel>("context_menu",
new object[] { selectedResult.ContextData }));

var results = ParseResults(res);
var results = ParseResults(res);

return results;
}
catch
{
return new List<Result>();
}
return results;
}

public override async Task<List<Result>> QueryAsync(Query query, CancellationToken token)
{
try
{
var res = await RPC.InvokeWithCancellationAsync<JsonRPCQueryResponseModel>("query",
new object[] { query, Settings.Inner },
token);
var res = await RPC.InvokeWithCancellationAsync<JsonRPCQueryResponseModel>("query",
new object[] { query, Settings.Inner },
token);

var results = ParseResults(res);
var results = ParseResults(res);

return results;
}
catch
{
return new List<Result>();
}
return results;
}


Expand Down
Loading