Remove Useless Separate Line for Blank Settings Panel

[Jack251970]

Remove Useless Separate Line for Blank Settings Panel

1. Remove useless settings control for C# plugin

Url plugin returns a blank control as settings panel, FL will add one more separate line making it uncomfortable:

After:

2. Remove useless settings control for JsonRPC plugin

Use null to let FL not add settings control. Before:

After:

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

🥷 Code experts: Yusyuriv

Yusyuriv has most 👩‍💻 activity in the files.
Yusyuriv has most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs

Activity based on git-commit:

	Yusyuriv
FEB
JAN
DEC
NOV	27 additions & 1 deletions
OCT
SEP

Knowledge based on git-blame:
Yusyuriv: 6%

Flow.Launcher/ViewModel/PluginViewModel.cs

Activity based on git-commit:

	Yusyuriv
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
Yusyuriv: 29%

Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj

Activity based on git-commit:

	Yusyuriv
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
Yusyuriv: 10%

Plugins/Flow.Launcher.Plugin.Url/Main.cs

Activity based on git-commit:

	Yusyuriv
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The update refines the settings handling across multiple components. In the core settings class, the method now returns null instead of a new control when no settings exist. The view model is adjusted to verify that a valid settings panel is available before reporting that a settings control exists. In addition, the URL plugin removes its settings support by dropping its ISettingProvider implementation, related UI files, and the corresponding project dependency on the infrastructure project.

Changes

File(s)	Change Summary
Flow.Launcher.Core/.../JsonRPCPluginSettings.cs Flow.Launcher/ViewModel/PluginViewModel.cs	Updated settings panel creation logic: now returns null when settings are empty and checks the existence of a valid panel in the view model.
Plugins/Flow.Launcher.Plugin.Url/.../Main.cs Plugins/Flow.Launcher.Plugin.Url/.../SettingsControl.xaml Plugins/Flow.Launcher.Plugin.Url/.../SettingsControl.xaml.cs	Removed settings UI support: eliminated the ISettingProvider interface implementation and the CreateSettingPanel method, along with deleting the settings UI files.
Plugins/Flow.Launcher.Plugin.Url/.../Flow.Launcher.Plugin.Url.csproj	Removed the project reference to Flow.Launcher.Infrastructure.

Sequence Diagram(s)

sequenceDiagram
    participant VM as PluginViewModel
    participant P as ISettingProvider
    VM->>P: Invoke CreateSettingPanel()
    alt Valid panel returned
        P-->>VM: Return non-null panel
        VM->>VM: Set HasSettingControl to true
    else No panel available
        P-->>VM: Return null
        VM->>VM: Set HasSettingControl to false
    end

Loading

Suggested labels

enhancement, bug

Suggested reviewers

• jjw24
• VictoriousRaptor

Poem

I'm a little bunny, coding under the moon,
Hoping my changes make the logic bloom.
I nibble bugs away with a playful little hop,
Chewing through code until errors drop.
With settings neat and tidy, I cheer in delight,
A happy rabbit dancing in the light!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a54eed and c472239.

📒 Files selected for processing (6)

• Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs (1 hunks)
• Flow.Launcher/ViewModel/PluginViewModel.cs (1 hunks)
• Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj (0 hunks)
• Plugins/Flow.Launcher.Plugin.Url/Main.cs (1 hunks)
• Plugins/Flow.Launcher.Plugin.Url/SettingsControl.xaml (0 hunks)
• Plugins/Flow.Launcher.Plugin.Url/SettingsControl.xaml.cs (0 hunks)

💤 Files with no reviewable changes (3)

• Plugins/Flow.Launcher.Plugin.Url/SettingsControl.xaml
• Plugins/Flow.Launcher.Plugin.Url/SettingsControl.xaml.cs
• Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: gitStream.cm

🔇 Additional comments (3)

Plugins/Flow.Launcher.Plugin.Url/Main.cs (1)

7-7: LGTM! Removal of ISettingProvider interface.

The removal of the ISettingProvider interface aligns with the PR objective of removing unnecessary visual elements in the settings panel.

Flow.Launcher/ViewModel/PluginViewModel.cs (1)

93-93: LGTM! Enhanced settings panel visibility logic.

The updated HasSettingControl property now correctly checks if a valid settings panel can be created, preventing the display of empty settings panels.

Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs (1)

114-115: LGTM! Return null for empty settings.

The change correctly returns null when Settings is empty, which works in conjunction with the PluginViewModel changes to prevent displaying unnecessary settings panels.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.