Improve Progress Box Design #3267
Conversation
This comment has been minimized.
This comment has been minimized.
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThis pull request adds a new localized string resource for "Background" in the English language file. Additionally, it updates the ProgressBoxEx dialog by adding a minimize button and a background action button. The corresponding event handlers in both XAML and C# files have been modified, with method names updated to better reflect their functionalities, and the window now includes the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as "ProgressBoxEx UI"
participant Handlers as "Event Handlers"
User->>UI: Click Cancel Button
UI->>Handlers: Trigger Button_Cancel()
Handlers-->>UI: Execute ForceClose()
User->>UI: Click Minimize Button
UI->>Handlers: Trigger Button_Minimize()
Handlers-->>UI: Set WindowState = Minimized
User->>UI: Click Background Button
UI->>Handlers: Trigger Button_Background()
Handlers-->>UI: Hide Window
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🧰 Additional context used🧠 Learnings (1)Flow.Launcher/ProgressBoxEx.xaml.cs (1)⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (10)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
@onesounds Sorry for the ping. What do you think of this design? |
Good. |
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
3 participants
Add minimize & background button for progress box & Set progress box topmost
Minimize button is for users to temporarily hide progress box for this progress when they do not want to check the progress for now. They can view progress if they want from taskbar.
Background button is for users to permanently hide progress for this progress when they do not care the progress. This will not cancel the progress. (It is different from cancel button & close button which is used to cancel the progress.)
Set progress box topmost since we support to temporarily and permanently hide this window now.
Test
Original:
New:
