Improve Wallpaper Retrieval

Flow.Launcher/Helper/WallpaperPathRetrieval.cs

@@ -1,9 +1,11 @@
 using System;
+using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Runtime.InteropServices;
-using System.Text;
-using System.Windows.Documents;
+using System.Windows;
 using System.Windows.Media;
+using System.Windows.Media.Imaging;
 using Microsoft.Win32;
 using Windows.Win32;
 using Windows.Win32.UI.WindowsAndMessaging;
@@ -14,7 +16,48 @@ public static class WallpaperPathRetrieval
 {
     private static readonly int MAX_PATH = 260;
 
-    public static unsafe string GetWallpaperPath()
+    private static readonly Dictionary<DateTime, ImageBrush> wallpaperCache = new();
+
+    public static Brush GetWallpaperBrush()
+    {
+        // Invoke the method on the UI thread
+        if (!Application.Current.Dispatcher.CheckAccess())
+        {
+            return Application.Current.Dispatcher.Invoke(GetWallpaperBrush);
+        }
+
+        var wallpaper = GetWallpaperPath();
+        if (wallpaper is not null && File.Exists(wallpaper))
+        {
+            // Since the wallpaper file name is the same (TranscodedWallpaper),
+            // we need to use the last modified date to differentiate them
+            var dateModified = File.GetLastWriteTime(wallpaper);
+            wallpaperCache.TryGetValue(dateModified, out var cachedWallpaper);
+            if (cachedWallpaper != null)
+            {
+                return cachedWallpaper;
+            }
+
+            // We should not dispose the memory stream since the bitmap is still in use
+            var memStream = new MemoryStream(File.ReadAllBytes(wallpaper));
+            var bitmap = new BitmapImage();
+            bitmap.BeginInit();
+            bitmap.StreamSource = memStream;
+            bitmap.DecodePixelWidth = 800;
+            bitmap.DecodePixelHeight = 600;
+            bitmap.EndInit();
+            bitmap.Freeze(); // Make the bitmap thread-safe
+            var wallpaperBrush = new ImageBrush(bitmap) { Stretch = Stretch.UniformToFill };
+            wallpaperBrush.Freeze(); // Make the brush thread-safe
+            wallpaperCache.Add(dateModified, wallpaperBrush);
+            return wallpaperBrush;
+        }
+
+        var wallpaperColor = GetWallpaperColor();
+        return new SolidColorBrush(wallpaperColor);
+    }
+
+    private static unsafe string GetWallpaperPath()
     {
         var wallpaperPtr = stackalloc char[MAX_PATH];
         PInvoke.SystemParametersInfo(SYSTEM_PARAMETERS_INFO_ACTION.SPI_GETDESKWALLPAPER, (uint)MAX_PATH,
@@ -25,7 +68,7 @@ public static unsafe string GetWallpaperPath()
         return wallpaper.ToString();
     }
 
-    public static Color GetWallpaperColor()
+    private static Color GetWallpaperColor()
     {
         RegistryKey key = Registry.CurrentUser.OpenSubKey(@"Control Panel\Colors", true);
         var result = key?.GetValue("Background", null);

Flow.Launcher/Resources/Pages/WelcomePage2.xaml.cs

@@ -5,8 +5,6 @@
 using System.Windows.Navigation;
 using CommunityToolkit.Mvvm.Input;
 using Flow.Launcher.ViewModel;
-using System.IO;
-using System.Windows.Media.Imaging;
 using System.Windows.Media;
 
 namespace Flow.Launcher.Resources.Pages
@@ -33,24 +31,7 @@ private static void SetTogglingHotkey(HotkeyModel hotkey)
 
         public Brush PreviewBackground
         {
-            get
-            {
-                var wallpaper = WallpaperPathRetrieval.GetWallpaperPath();
-                if (wallpaper is not null && File.Exists(wallpaper))
-                {
-                    var memStream = new MemoryStream(File.ReadAllBytes(wallpaper));
-                    var bitmap = new BitmapImage();
-                    bitmap.BeginInit();
-                    bitmap.StreamSource = memStream;
-                    bitmap.DecodePixelWidth = 800;
-                    bitmap.DecodePixelHeight = 600;
-                    bitmap.EndInit();
-                    return new ImageBrush(bitmap) { Stretch = Stretch.UniformToFill };
-                }
-
-                var wallpaperColor = WallpaperPathRetrieval.GetWallpaperColor();
-                return new SolidColorBrush(wallpaperColor);
-            }
+            get => WallpaperPathRetrieval.GetWallpaperBrush();
         }
     }
 }

Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs

@@ -5,7 +5,6 @@
 using System.IO;
 using System.Linq;
 using System.Windows.Media;
-using System.Windows.Media.Imaging;
 using CommunityToolkit.Mvvm.Input;
 using Flow.Launcher.Core.Resource;
 using Flow.Launcher.Helper;
@@ -14,7 +13,6 @@
 using Flow.Launcher.Plugin;
 using Flow.Launcher.ViewModel;
 using ModernWpf;
-using Flow.Launcher.Core;
 using ThemeManager = Flow.Launcher.Core.Resource.ThemeManager;
 using ThemeManagerForColorSchemeSwitch = ModernWpf.ThemeManager;
 
@@ -212,24 +210,7 @@ public bool UseDate
 
     public Brush PreviewBackground
     {
-        get
-        {
-            var wallpaper = WallpaperPathRetrieval.GetWallpaperPath();
-            if (wallpaper is not null && File.Exists(wallpaper))
-            {
-                var memStream = new MemoryStream(File.ReadAllBytes(wallpaper));
-                var bitmap = new BitmapImage();
-                bitmap.BeginInit();
-                bitmap.StreamSource = memStream;
-                bitmap.DecodePixelWidth = 800;
-                bitmap.DecodePixelHeight = 600;
-                bitmap.EndInit();
-                return new ImageBrush(bitmap) { Stretch = Stretch.UniformToFill };
-            }
-
-            var wallpaperColor = WallpaperPathRetrieval.GetWallpaperColor();
-            return new SolidColorBrush(wallpaperColor);
-        }
+        get => WallpaperPathRetrieval.GetWallpaperBrush();
     }
 
     public ResultsViewModel PreviewResults