Fix NumberBox Placeholder text color #3485
Conversation
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
| </Trigger> | ||
| <Trigger Property="IsEnabled" Value="false"> | ||
| <Setter TargetName="HeaderContentPresenter" Property="Foreground" Value="{DynamicResource TextControlHeaderForegroundDisabled}" /> | ||
| <Setter Property="Background" Value="{DynamicResource CustomNumberBoxBGDisabled}" /> |
There was a problem hiding this comment.
I had worked on this key, but now I see it’s not used anywhere. Since the intended color is being displayed correctly, I’ve removed this part.
This comment has been minimized.
This comment has been minimized.
|
🥷 Code experts: no user but you matched threshold 10 onesounds has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
📝 WalkthroughWalkthroughThis update modifies the visual styling of NumberBox controls in the application's resource dictionaries. Specifically, it removes the background color setter for the disabled state in the NumberBoxTextBoxStyle template, so the background is no longer forcibly set when the control is disabled. Additionally, a new color resource for NumberBox placeholders is introduced in the dark theme resource dictionary. No changes to logic, exported, or public entities are present. Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| <Color x:Key="NumberBoxColor24">#f5f5f5</Color> | ||
| <Color x:Key="NumberBoxColor25">#464646</Color> | ||
| <Color x:Key="NumberBoxColor26">#ffffff</Color> | ||
| <SolidColorBrush x:Key="NumberBoxPlaceHolder" Color="#464646" /> |
There was a problem hiding this comment.
It was only present in Light mode and missing in Dark, so I’ve added it.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Jack251970
added
kind/ui
2 participants
What's the PR
Before
After
Comment
I clearly remember working on it and even testing it, but in the current dev build, the style is missing in dark mode. I also removed another unused style that wasn’t in the color list at all—though I’m pretty sure I worked on that too. I tried checking if I did it in another PR, but couldn’t find anything. Either aliens have tampered with my memory, or early-onset dementia is setting in. If I end up in a nursing home someday, please consider donating a portion of your funds in my memory.