Skip to content

Fix history results clear logic & Make sure results cleared #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Fix history results clear logic & Make sure results cleared #3525

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3718796
Fix history results clear logic
Jack251970 May 10, 2025
54d50cf
Remove async
Jack251970 May 11, 2025
5784f87
Make sure results cleared when update tasks are not called
Jack251970 May 11, 2025
3484d08
Fix result clear flag issue
Jack251970 May 11, 2025
021b451
Improve code comments & Move flag position
Jack251970 May 11, 2025
6e473c8
Fix page flickering when typing is very fast
Jack251970 May 14, 2025
c8989c3
Fix results clear issue with one flag
Jack251970 May 14, 2025
3436ac9
Adjust check position
Jack251970 May 14, 2025
08447da
Move clear results to local function
Jack251970 May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Flow.Launcher/ViewModel/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,8 +1284,6 @@ private async Task QueryResultsAsync(bool searchDelay, bool isReQuery = false, b
// Update the query's IsReQuery property to true if this is a re-query
query.IsReQuery = isReQuery;



ICollection<PluginPair> plugins = Array.Empty<PluginPair>();
if (currentIsHomeQuery)
{
Expand Down Expand Up @@ -1458,8 +1456,13 @@ void QueryHistoryTask(CancellationToken token)

App.API.LogDebug(ClassName, $"Update results for history");

// Indicate if to clear existing results so to show only ones from plugins with action keywords
var shouldClearExistingResults = ShouldClearExistingResults(query, currentIsHomeQuery);
_lastQuery = query;
_previousIsHomeQuery = currentIsHomeQuery;

if (!_resultsUpdateChannelWriter.TryWrite(new ResultsForUpdate(results, _historyMetadata, query,
token)))
token, reSelect, shouldClearExistingResults)))
{
App.API.LogError(ClassName, "Unable to add item to Result Update Queue");
}
Expand Down
Loading