Fix possible null exception in plugin store item view model #3556

Jack251970 · 2025-05-19T05:28:07Z

Resolve #3555.

gitstream-cm · 2025-05-19T05:29:13Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

coderabbitai · 2025-05-19T05:30:49Z

📝 Walkthrough

"""

Walkthrough

A null-conditional check was added to the ShowCommandQuery method in PluginStoreItemViewModel.cs to prevent a possible NullReferenceException when accessing ActionKeywords. The logic now safely handles cases where ActionKeywords may be null, ensuring robust execution without altering the method’s overall functionality.

Changes

File(s)	Change Summary
Flow.Launcher/ViewModel/PluginStoreItemViewModel.cs	Added null-conditional and explicit null checks for `ActionKeywords` in `ShowCommandQuery` to prevent null reference exceptions.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent NullReferenceException in PluginStoreItemViewModel when ActionKeywords is null (#3555)	✅

Suggested reviewers

taooceros
jjw24

Poem

A bug hopped in with a NullReference scare,
But now with a check, there’s nothing to fear!
No more exceptions will boggle the night,
The code’s safe and sound, and everything’s right.
🐇✨
"""

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e59903a and ab1dd2e.

📒 Files selected for processing (1)

Flow.Launcher/ViewModel/PluginStoreItemViewModel.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Flow.Launcher/ViewModel/PluginStoreItemViewModel.cs

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: gitStream.cm
GitHub Check: build

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR adds a null check for ActionKeywords in the plugin store item view model to prevent a possible null reference exception when building the command query.

Added a null-conditional check (?.Any()) on ActionKeywords
Switched to a lowercase string literal for the empty fallback

Comments suppressed due to low confidence (1)

Flow.Launcher/ViewModel/PluginStoreItemViewModel.cs:64

The code uses string.empty, which is not a valid C# member. Use string.Empty (capital E) or String.Empty instead.

var actionKeyword = (PluginManagerData.Metadata.ActionKeywords?.Any() ?? false) ? PluginManagerData.Metadata.ActionKeywords[0] + " " : string.empty;

jjw24 · 2025-05-19T07:57:02Z

Flow.Launcher/ViewModel/PluginStoreItemViewModel.cs

        private void ShowCommandQuery(string action)
        {
-            var actionKeyword = PluginManagerData.Metadata.ActionKeywords.Any() ? PluginManagerData.Metadata.ActionKeywords[0] + " " : String.Empty;
+            var actionKeyword = (PluginManagerData.Metadata?.ActionKeywords?.Any() == true) ? PluginManagerData.Metadata.ActionKeywords[0] + " " : string.Empty;


What would cause them to be null?

Metadata: perhaps file is not found or read failed
ActionKeywords: not initialized?

I am also very curious why this could happen, and could you please also check that issue?

Yeah that issue doesn't provide much information we will need to wait for the issuer to reply.

I don't think this is a good fix, it will hide the underlying issue. Logically that shouldn't be null because it's Plugins manager.

Can you check if you can reproduce if you uninstalled the PluginsManager

I think that can cause PluginManagerData to be null. Let us ask the user first to confirm it.

github-actions · 2025-05-22T02:12:14Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

gitstream-cm · 2025-05-22T02:13:13Z

🥷 Code experts: no user matched threshold 10

See details

To learn more about /:\ gitStream - Visit our Docs

prlabeler bot added the bug Something isn't working label May 19, 2025

github-actions bot assigned Jack251970 May 19, 2025

This comment has been minimized.

Sign in to view

Jack251970 enabled auto-merge May 19, 2025 05:31

Jack251970 requested a review from Copilot May 19, 2025 05:31

Copilot AI reviewed May 19, 2025

View reviewed changes

Jack251970 requested a review from jjw24 May 19, 2025 05:33

Jack251970 added this to the 1.20.0 milestone May 19, 2025

This comment has been minimized.

Sign in to view

gitstream-cm bot added the 1 min review label May 19, 2025

jjw24 reviewed May 19, 2025

View reviewed changes

Jack251970 modified the milestones: 1.20.0, Future May 19, 2025

Jack251970 closed this May 22, 2025

auto-merge was automatically disabled May 22, 2025 02:11
Pull request was closed

Jack251970 force-pushed the plugin_store_item_vm_null branch from ab1dd2e to 60de423 Compare May 22, 2025 02:11

Jack251970 removed the 1 min review label May 22, 2025

Jack251970 removed this from the Future milestone May 22, 2025

Uh oh!

Fix possible null exception in plugin store item view model #3556

Fix possible null exception in plugin store item view model #3556

Uh oh!

Conversation

Jack251970 commented May 19, 2025

Uh oh!

This comment has been minimized.

gitstream-cm bot commented May 19, 2025

Uh oh!

coderabbitai bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

This comment has been minimized.

jjw24 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Jack251970 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

jjw24 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

jjw24 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Jack251970 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 22, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

gitstream-cm bot commented May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented May 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)