Improve File Manager Configuration Error Handling

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -226,8 +226,8 @@ public CustomExplorerViewModel CustomExplorer
             new()
             {
                 Name = "Files",
-                Path = "Files",
-                DirectoryArgument = "-select \"%d\"",
+                Path = "Files-Stable",
+                DirectoryArgument = "\"%d\"",
                 FileArgument = "-select \"%f\""
             }
         };

Flow.Launcher/Languages/en.xaml

@@ -366,13 +366,17 @@
 
     <!--  FileManager Setting Dialog  -->
     <system:String x:Key="fileManagerWindow">Select File Manager</system:String>
+    <system:String x:Key="fileManager_files_btn">Do you use Files?</system:String>
+    <system:String x:Key="fileManager_files_tips">Depending on the version, Files may use either "Files" or "Files-stable" as its path. (This can vary depending on which version you're using.) For more details, see:</system:String>
     <system:String x:Key="fileManager_tips">Please specify the file location of the file manager you using and add arguments as required. The &quot;%d&quot; represents the directory path to open for, used by the Arg for Folder field and for commands opening specific directories. The &quot;%f&quot; represents the file path to open for, used by the Arg for File field and for commands opening specific files.</system:String>
     <system:String x:Key="fileManager_tips2">For example, if the file manager uses a command such as &quot;totalcmd.exe /A c:\windows&quot; to open the c:\windows directory, the File Manager Path will be totalcmd.exe, and the Arg For Folder will be /A &quot;%d&quot;. Certain file managers like QTTabBar may just require a path to be supplied, in this instance use &quot;%d&quot; as the File Manager Path and leave the rest of the fileds blank.</system:String>
     <system:String x:Key="fileManager_name">File Manager</system:String>
     <system:String x:Key="fileManager_profile_name">Profile Name</system:String>
     <system:String x:Key="fileManager_path">File Manager Path</system:String>
     <system:String x:Key="fileManager_directory_arg">Arg For Folder</system:String>
     <system:String x:Key="fileManager_file_arg">Arg For File</system:String>
+    <system:String x:Key="fileManagerPathNotFound">The path for the file manager '{0}' could not be found: '{1}' Do you want to continue?</system:String>
+    <system:String x:Key="fileManagerPathError">File Manager Path Error</system:String>
 
     <!--  DefaultBrowser Setting Dialog  -->
     <system:String x:Key="defaultBrowserTitle">Default Web Browser</system:String>
@@ -462,6 +466,14 @@
     <system:String x:Key="reportWindow_upload_log">1. Upload log file: {0}</system:String>
     <system:String x:Key="reportWindow_copy_below">2. Copy below exception message</system:String>
 
+    <!--  File Open Error  -->
+    <system:String x:Key="fileManagerNotFoundTitle">File Manager Error</system:String>
+    <system:String x:Key="fileManagerNotFound">
+        The specified file manager could not be found. Please check the Custom File Manager setting under Settings >General.
+    </system:String>
+    <system:String x:Key="errorTitle">Error</system:String>
+    <system:String x:Key="folderOpenError">An error occurred while opening the folder. {0}</system:String>
+
     <!--  General Notice  -->
     <system:String x:Key="pleaseWait">Please wait...</system:String>
 

Flow.Launcher/PublicAPIInstance.cs

@@ -42,11 +42,11 @@
 
         // Must use getter to avoid accessing Application.Current.Resources.MergedDictionaries so earlier in theme constructor
         private Theme _theme;
         private Theme Theme => _theme ??= Ioc.Default.GetRequiredService<Theme>();
 
         // Must use getter to avoid circular dependency
         private Updater _updater;
         private Updater Updater => _updater ??= Ioc.Default.GetRequiredService<Updater>();
 
         private readonly object _saveSettingsLock = new();
 
@@ -142,7 +142,7 @@
             ShellCommand.Execute(startInfo);
         }
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "VSTHRD100:Avoid async void methods", Justification = "<Pending>")]
         public async void CopyToClipboard(string stringToCopy, bool directCopy = false, bool showDefaultNotification = true)
         {
             if (string.IsNullOrEmpty(stringToCopy))
@@ -316,40 +316,63 @@
 
         public void OpenDirectory(string DirectoryPath, string FileNameOrFilePath = null)
         {
-            using var explorer = new Process();
-            var explorerInfo = _settings.CustomExplorer;
-            var explorerPath = explorerInfo.Path.Trim().ToLowerInvariant();
-            var targetPath = FileNameOrFilePath is null
-                ? DirectoryPath
-                : Path.IsPathRooted(FileNameOrFilePath)
-                    ? FileNameOrFilePath
-                    : Path.Combine(DirectoryPath, FileNameOrFilePath);
-
-            if (Path.GetFileNameWithoutExtension(explorerPath) == "explorer")
+            try
             {
-                // Windows File Manager
-                // We should ignore and pass only the path to Shell to prevent zombie explorer.exe processes
-                explorer.StartInfo = new ProcessStartInfo
+                using var explorer = new Process();
+                var explorerInfo = _settings.CustomExplorer;
+                var explorerPath = explorerInfo.Path.Trim().ToLowerInvariant();
+                var targetPath = FileNameOrFilePath is null
+                    ? DirectoryPath
+                    : Path.IsPathRooted(FileNameOrFilePath)
+                        ? FileNameOrFilePath
+                        : Path.Combine(DirectoryPath, FileNameOrFilePath);
+
+                if (Path.GetFileNameWithoutExtension(explorerPath) == "explorer")
                 {
-                    FileName = targetPath,         // Not explorer, Only path.
-                    UseShellExecute = true         // Must be true to open folder
-                };
+                    // Windows File Manager
+                    explorer.StartInfo = new ProcessStartInfo
+                    {
+                        FileName = targetPath,
+                        UseShellExecute = true
+                    };
+                }
+                else
+                {
+                    // Custom File Manager
+                    explorer.StartInfo = new ProcessStartInfo
+                    {
+                        FileName = explorerInfo.Path.Replace("%d", DirectoryPath),
+                        UseShellExecute = true,
+                        Arguments = FileNameOrFilePath is null
+                            ? explorerInfo.DirectoryArgument.Replace("%d", DirectoryPath)
+                            : explorerInfo.FileArgument
+                                .Replace("%d", DirectoryPath)
+                                .Replace("%f", targetPath)
+                    };
+                }
+
+                explorer.Start();
             }
-            else
+            catch (System.ComponentModel.Win32Exception ex) when (ex.NativeErrorCode == 2)
             {
-                // Custom File Manager
-                explorer.StartInfo = new ProcessStartInfo
-                {
-                    FileName = explorerInfo.Path.Replace("%d", DirectoryPath),
-                    UseShellExecute = true,
-                    Arguments = FileNameOrFilePath is null
-                        ? explorerInfo.DirectoryArgument.Replace("%d", DirectoryPath)
-                        : explorerInfo.FileArgument
-                            .Replace("%d", DirectoryPath)
-                            .Replace("%f", targetPath)
-                };
+                // File Manager not found
+                MessageBoxEx.Show(
+                    string.Format(GetTranslation("fileManagerNotFound"), ex.Message),
+                    GetTranslation("fileManagerNotFoundTitle"),
+                    MessageBoxButton.OK,
+                    MessageBoxImage.Error
+                );
+            }
+            catch (Exception ex)
+            {
+                // Other exceptions
+                MessageBoxEx.Show(
+                    string.Format(GetTranslation("folderOpenError"), ex.Message),
+                    GetTranslation("errorTitle"),
+                    MessageBoxButton.OK,
+                    MessageBoxImage.Error
+                );
             }
-            explorer.Start();
         }
 
         private void OpenUri(Uri uri, bool? inPrivate = null)

Flow.Launcher/SelectFileManagerWindow.xaml

@@ -73,9 +73,18 @@
                         <TextBlock Margin="0 14 0 0" FontSize="14">
                             <TextBlock Text="{DynamicResource fileManager_tips2}" TextWrapping="WrapWithOverflow" />
                         </TextBlock>
+                        <Button
+                            x:Name="btnTips"
+                            Margin="0 14 0 0"
+                            HorizontalAlignment="Left"
+                            Click="btnTips_Click"
+                            Content="{DynamicResource fileManager_files_btn}" />
                     </StackPanel>
-
-                    <StackPanel Margin="14 28 0 0" Orientation="Horizontal">
+                    <Rectangle
+                        Height="1"
+                        Margin="0 20 0 20"
+                        Fill="{StaticResource SeparatorForeground}" />
+                    <StackPanel Margin="14 0 0 0" Orientation="Horizontal">
                         <TextBlock
                             Grid.Column="1"
                             HorizontalAlignment="Left"
@@ -111,7 +120,7 @@
                     <Rectangle
                         Height="1"
                         Margin="0 20 0 12"
-                        Fill="{StaticResource Color03B}" />
+                        Fill="{StaticResource SeparatorForeground}" />
                     <StackPanel
                         Margin="0 0 0 0"
                         HorizontalAlignment="Stretch"

Flow.Launcher/SelectFileManagerWindow.xaml.cs

@@ -1,11 +1,16 @@
-using System.Collections.ObjectModel;
+using System;
+using System.Collections.ObjectModel;
 using System.ComponentModel;
+using System.Diagnostics;
+using System.IO;
 using System.Linq;
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Documents;
 using CommunityToolkit.Mvvm.ComponentModel;
 using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.ViewModel;
+using ModernWpf.Controls;
 
 namespace Flow.Launcher
 {
@@ -43,11 +48,106 @@
 
         private void btnDone_Click(object sender, RoutedEventArgs e)
         {
+            // Check if the selected file manager path is valid
+            if (!IsFileManagerValid(CustomExplorer.Path))
+            {
+                MessageBoxResult result = MessageBoxEx.Show(
+                    string.Format((string)Application.Current.FindResource("fileManagerPathNotFound"), 
+                        CustomExplorer.Name, CustomExplorer.Path),
+                    (string)Application.Current.FindResource("fileManagerPathError"),
+                    MessageBoxButton.YesNo,
+                    MessageBoxImage.Warning);
+
+                if (result == MessageBoxResult.No)
+                {
+                    return;
+                }
+            }
+
             _settings.CustomExplorerList = CustomExplorers.ToList();
             _settings.CustomExplorerIndex = SelectedCustomExplorerIndex;
             Close();
         }
 
+        private bool IsFileManagerValid(string path)
+        {
+            if (string.Equals(path, "explorer", StringComparison.OrdinalIgnoreCase))
+                return true;
+
+            if (Path.IsPathRooted(path))
+            {
+                return File.Exists(path);
+            }
+
+            try
+            {
+                var process = new Process
+                {
+                    StartInfo = new ProcessStartInfo
+                    {
+                        FileName = "where",
+                        Arguments = path,
+                        RedirectStandardOutput = true,
+                        UseShellExecute = false,
+                        CreateNoWindow = true
+                    }
+                };
+                process.Start();
+                string output = process.StandardOutput.ReadToEnd();
+                process.WaitForExit();
+
+                return !string.IsNullOrEmpty(output);
+            }
+            catch
+            {
+                return false;
+            }
+        }
+
+        private async void btnTips_Click(object sender, RoutedEventArgs e)
+        {
+            string tipText = (string)Application.Current.Resources["fileManager_files_tips"];
+            string url = "https://files.community/docs/contributing/updates";
+
+            var textBlock = new TextBlock
+            {
+                FontSize = 14,
+                TextWrapping = TextWrapping.Wrap,
+                Margin = new Thickness(0, 0, 0, 0)
+            };
+
+            textBlock.Inlines.Add(tipText);
+
+            Hyperlink hyperlink = new Hyperlink
+            {
+                NavigateUri = new Uri(url)
+            };
+            hyperlink.Inlines.Add(url);
+            hyperlink.RequestNavigate += (s, args) =>
+            {
+                Process.Start(new ProcessStartInfo
+                {
+                    FileName = args.Uri.AbsoluteUri,
+                    UseShellExecute = true
+                });
+                args.Handled = true;
+            };
+
+            textBlock.Inlines.Add(hyperlink);
+
+            var tipsDialog = new ContentDialog()
+            {
+                Owner = Window.GetWindow(sender as DependencyObject),
+                Title = (string)Application.Current.Resources["fileManager_files_btn"],
+                Content = textBlock,
+                PrimaryButtonText = (string)Application.Current.Resources["commonOK"],
+                CornerRadius = new CornerRadius(8),
+                Style = (Style)Application.Current.Resources["ContentDialog"]
+            };
+
+            await tipsDialog.ShowAsync();
+        }
+
         private void btnAdd_Click(object sender, RoutedEventArgs e)
         {
             CustomExplorers.Add(new()