Fix main window null when checking exiting

[Jack251970]

If we call Win+R before creating main window, the Show will be called before main window constructor. So we need to check if main window is created.

Please open new issue in https://github.com/Flow-Launcher/Flow.Launcher/issues
1. Upload log file: C:\Users\11602\AppData\Roaming\FlowLauncher\Logs\1.19.5\2025-05-22.txt
2. Copy below exception message

Flow Launcher version: 1.19.5
OS Version: 26100.4061
IntPtr Length: 8
x64: True

Python Path: C:\Users\11602\AppData\Roaming\FlowLauncher\Environments\Python\PythonEmbeddable-v3.11.4\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe

Date: 05/22/2025 18:33:08
Exception:
System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (Object reference not set to an instance of an object.)
 ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Flow.Launcher.App.get_Exiting() in C:\projects\flow-launcher\Flow.Launcher\App.xaml.cs:line 35
   at Flow.Launcher.ViewModel.MainViewModel.Show() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 1732
   at Flow.Launcher.PublicAPIInstance.ShowMainWindow() in C:\projects\flow-launcher\Flow.Launcher\PublicAPIInstance.cs:line 95
   at Flow.Launcher.App.OnSecondAppStarted() in C:\projects\flow-launcher\Flow.Launcher\App.xaml.cs:line 379
   at Flow.Launcher.Helper.SingleInstance`1.ActivateFirstInstance() in C:\projects\flow-launcher\Flow.Launcher\Helper\SingleInstance.cs:line 138
   at System.Windows.Threading.DispatcherOperation.InvokeDelegateCore()
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
--- End of stack trace from previous location ---
   at System.Windows.Threading.DispatcherOperation.Wait(TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherOperation operation, CancellationToken cancellationToken, TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.Invoke(Action callback, DispatcherPriority priority, CancellationToken cancellationToken, TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.Invoke(Action callback)
   at Flow.Launcher.Helper.SingleInstance`1.CreateRemoteServiceAsync(String channelName) in C:\projects\flow-launcher\Flow.Launcher\Helper\SingleInstance.cs:line 103
   --- End of inner exception stack trace ---

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the logic for determining application state by replacing the Exiting property with LoadingOrExiting. This affects multiple locations where the application checks whether it is safe to perform actions such as saving settings or showing windows, now considering both loading and exiting states.

Changes

File(s)	Change Summary
Flow.Launcher/App.xaml.cs	Renamed static property Exiting to LoadingOrExiting and broadened its logic to include loading state.
Flow.Launcher/SettingWindow.xaml.cs Flow.Launcher/ViewModel/MainViewModel.cs Flow.Launcher/WelcomeWindow.xaml.cs	Updated checks from App.Exiting to App.LoadingOrExiting to reflect the new logic when saving settings or showing windows.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant MainWindow
    participant SettingsWindow
    participant WelcomeWindow

    App->>App: Check LoadingOrExiting
    alt LoadingOrExiting is true
        Note right of App: Skip showing windows or saving settings
    else LoadingOrExiting is false
        MainWindow->>App: Show()
        SettingsWindow->>App: Save settings on close
        WelcomeWindow->>App: Save settings on close
    end

Loading

Suggested reviewers

• taooceros
• jjw24

Poem

In the warren of code, a change takes flight,
Now loading or exiting, we check day and night.
No more saving in haste, or windows aglow,
When the app isn’t ready, we simply say no.
🐇 With logic refined, our launch is just right!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac61469 and 8aae92e.

📒 Files selected for processing (4)

• Flow.Launcher/App.xaml.cs (1 hunks)
• Flow.Launcher/SettingWindow.xaml.cs (1 hunks)
• Flow.Launcher/ViewModel/MainViewModel.cs (1 hunks)
• Flow.Launcher/WelcomeWindow.xaml.cs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (3)

Flow.Launcher/WelcomeWindow.xaml.cs (1)

Flow.Launcher/App.xaml.cs (2)

• App (30-383)
• App (55-136)

Flow.Launcher/SettingWindow.xaml.cs (1)

Flow.Launcher/App.xaml.cs (2)

• App (30-383)
• App (55-136)

Flow.Launcher/ViewModel/MainViewModel.cs (1)

Flow.Launcher/App.xaml.cs (2)

• App (30-383)
• App (55-136)

🪛 GitHub Actions: Check Spelling

Flow.Launcher/App.xaml.cs

[warning] 117-126: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 119-130: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 174-180: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 190-200: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 199-238: Loadertask is not a recognized word. (unrecognized-spelling)

---

[warning] 225-231: VSTHRD is not a recognized word. (unrecognized-spelling)

Flow.Launcher/ViewModel/MainViewModel.cs

[warning] 1727-1731: VSTHRD is not a recognized word. (unrecognized-spelling)

---

[warning] 1845-1851: VSTHRD is not a recognized word. (unrecognized-spelling)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (4)

Flow.Launcher/App.xaml.cs (1)

35-35: Good solution for addressing the null window issue

This property change from Exiting to LoadingOrExiting elegantly handles both cases when the application is still initializing (_mainWindow == null) and when it's shutting down (_mainWindow.CanClose). This directly addresses the issue when Win+R is pressed before the main window is created.

Flow.Launcher/WelcomeWindow.xaml.cs (1)

99-99: Consistent handling of app state

Updated to use the new LoadingOrExiting property, which now properly handles both initialization and shutdown scenarios, preventing potential issues when saving settings while the app is still loading.

Flow.Launcher/ViewModel/MainViewModel.cs (1)

1732-1732: Critical fix for the null window issue

This change directly addresses the issue described in the PR. The Show() method now checks both loading and exiting states, preventing the null reference exception that would occur when Win+R is pressed before the main window is created.

Flow.Launcher/SettingWindow.xaml.cs (1)

85-85: Consistent handling of app state

Updated to use the new LoadingOrExiting property, ensuring settings aren't saved during initialization or shutdown phases. This change maintains consistency with the other UI components.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.